New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悶 Instances of apps created from packages deployed via Site Collection Scoped App Catalogs aren't upgrading #1146

Closed
andrewconnell opened this Issue Dec 14, 2017 · 8 comments

Comments

Projects
None yet
5 participants
@andrewconnell
Collaborator

andrewconnell commented Dec 14, 2017

Category

  • Question
  • Typo
  • Bug
  • Additional article idea

Expected or Desired Behavior

  • deploy and trust app package to site collection app catalog
    • solution & feature within the solution that provisions a site column are version 1.0.0.0
  • create an instance of the app in the same site
  • make some changes and update the solution number and feature within the solution... update versions to 2.0.0.0
  • deploy solution that upgrades the existing package in the site collection scoped app catalog:

image

  • go to Site Contents page and either...
    • (a) don't wait 24 hrs as explained in this doc, click the "..." to get an ABOUT menu item where you can upgrade the instance or
    • (b) wait 24hrs to see the UPGRADE option

Observed Behavior

Neither option (a) above is shown...

image

nor option (b) is working (waited over 36 hours).

Steps to Reproduce

See Expected or Desired Behavior section above.

@cwdata

This comment has been minimized.

Show comment
Hide comment
@cwdata

cwdata Dec 14, 2017

Hi,
I experienced similar issues. It seems though, that the installed App itself is getting automatically upgraded but the displayed version number in Site contents just stays the same forever.
At least for my SPFx Webparts that is the case which is irritating. I don't have a feature upgrade code in my solutions so I don't know if that would be executed or not.

cwdata commented Dec 14, 2017

Hi,
I experienced similar issues. It seems though, that the installed App itself is getting automatically upgraded but the displayed version number in Site contents just stays the same forever.
At least for my SPFx Webparts that is the case which is irritating. I don't have a feature upgrade code in my solutions so I don't know if that would be executed or not.

@VesaJuvonen

This comment has been minimized.

Show comment
Hide comment
@VesaJuvonen

VesaJuvonen Dec 14, 2017

Contributor

thx @andrewconnell for reporting this. We'll start working on the issue investigation immediately. I have some hunch on what goes wrong, but good to have this reported here, so that others will know about the issue and that we can more easily track as we proceed with the fix for this.

Contributor

VesaJuvonen commented Dec 14, 2017

thx @andrewconnell for reporting this. We'll start working on the issue investigation immediately. I have some hunch on what goes wrong, but good to have this reported here, so that others will know about the issue and that we can more easily track as we proceed with the fix for this.

@VesaJuvonen

This comment has been minimized.

Show comment
Hide comment
@VesaJuvonen

VesaJuvonen Dec 14, 2017

Contributor

Just to evolve this - first things first always on our side (engineering) is to build a repro... and we have it with the same results as what @andrewconnell reported. I can confirm that this is clearly a bug, which we'll need to get fixed.

Contributor

VesaJuvonen commented Dec 14, 2017

Just to evolve this - first things first always on our side (engineering) is to build a repro... and we have it with the same results as what @andrewconnell reported. I can confirm that this is clearly a bug, which we'll need to get fixed.

@JeremyKelley

This comment has been minimized.

Show comment
Hide comment
@JeremyKelley

JeremyKelley Dec 14, 2017

One thing to note in the short term as we work on the issue is that you can uninstall the app and reinstall it. Any associated data shouldn't be lost so you should be able to upgrade that way as a last resort.

JeremyKelley commented Dec 14, 2017

One thing to note in the short term as we work on the issue is that you can uninstall the app and reinstall it. Any associated data shouldn't be lost so you should be able to upgrade that way as a last resort.

@VesaJuvonen

This comment has been minimized.

Show comment
Hide comment
@VesaJuvonen

VesaJuvonen Dec 15, 2017

Contributor

Like @JeremyKelley noted, doing uninstall/install is the current workaround for this and no data is being lost with the SPFx solution case when that's being done (SP hosted add-in would be a different story). The bug has been now identified and fixed. We will do final verifications and roll out the fix after that. Due however holiday freeze period, fix will be rolling out in January. We'll follow up on this issue when the fix is fully deployed. Thanks again for the detailed issue reporting and contacting us immediately when you noticed this.

  • ETA for fix arrival - mid-Jan.
  • Workaround for SPFx solutions - Uninstall/Install
Contributor

VesaJuvonen commented Dec 15, 2017

Like @JeremyKelley noted, doing uninstall/install is the current workaround for this and no data is being lost with the SPFx solution case when that's being done (SP hosted add-in would be a different story). The bug has been now identified and fixed. We will do final verifications and roll out the fix after that. Due however holiday freeze period, fix will be rolling out in January. We'll follow up on this issue when the fix is fully deployed. Thanks again for the detailed issue reporting and contacting us immediately when you noticed this.

  • ETA for fix arrival - mid-Jan.
  • Workaround for SPFx solutions - Uninstall/Install
@andrewconnell

This comment has been minimized.

Show comment
Hide comment
@andrewconnell

andrewconnell Dec 15, 2017

Collaborator

Thanks for the additional followup & detail @JeremyKelley & @VesaJuvonen

As a bit of feedback, this might be the best issue summary I've ever seen on GH. Concise, clear & everyone can know exactly where the issue is at the moment with an expectation of the resolution. Cheers guys... great to see this coming from this team! :)

Collaborator

andrewconnell commented Dec 15, 2017

Thanks for the additional followup & detail @JeremyKelley & @VesaJuvonen

As a bit of feedback, this might be the best issue summary I've ever seen on GH. Concise, clear & everyone can know exactly where the issue is at the moment with an expectation of the resolution. Cheers guys... great to see this coming from this team! :)

@andrewconnell

This comment has been minimized.

Show comment
Hide comment
@andrewconnell

andrewconnell Dec 19, 2017

Collaborator

@JeremyKelley & @VesaJuvonen - Can I get a clarification on what @JeremyKelley said here. When you say:

you can uninstall the app and reinstall it. Any associated data shouldn't be lost so you should be able to upgrade that way as a last resort

Are you saying I can uninstall the app from the Site Catalog App Catalog (not the Tenant scoped App Catalog) & reinstall it once it's been removed & that would apply v2 of my feature? Part of my provisioned feature v2 includes an upgrade action that applies an element manifest (creating a new site column) & adds the column to a content type that should apply to the list the v1 feature provisioned. If I remove the app and reinstall it, I'm getting an error (typical SP error with no details but a correlation ID) which I presume is because it's trying to recreate the list that already exists from the first time I installed the app.

As such, I can't test the feature upgrade actions within a SPSite scoped app catalog. If that's expected and I need to wait until mid-January, that's fine. Just trying to get clarification on the workaround mentioned above as it's not what I'm experiencing.

Collaborator

andrewconnell commented Dec 19, 2017

@JeremyKelley & @VesaJuvonen - Can I get a clarification on what @JeremyKelley said here. When you say:

you can uninstall the app and reinstall it. Any associated data shouldn't be lost so you should be able to upgrade that way as a last resort

Are you saying I can uninstall the app from the Site Catalog App Catalog (not the Tenant scoped App Catalog) & reinstall it once it's been removed & that would apply v2 of my feature? Part of my provisioned feature v2 includes an upgrade action that applies an element manifest (creating a new site column) & adds the column to a content type that should apply to the list the v1 feature provisioned. If I remove the app and reinstall it, I'm getting an error (typical SP error with no details but a correlation ID) which I presume is because it's trying to recreate the list that already exists from the first time I installed the app.

As such, I can't test the feature upgrade actions within a SPSite scoped app catalog. If that's expected and I need to wait until mid-January, that's fine. Just trying to get clarification on the workaround mentioned above as it's not what I'm experiencing.

@mcmynn83

This comment has been minimized.

Show comment
Hide comment
@mcmynn83

mcmynn83 Jan 18, 2018

This fix has now rolled out to production and you should no longer be seeing the issue. Please respond if it is still a problem for you.

mcmynn83 commented Jan 18, 2018

This fix has now rolled out to production and you should no longer be seeing the issue. Please respond if it is still a problem for you.

@mcmynn83 mcmynn83 closed this Jan 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment