New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knockout web part disappears when running in SharePoint workbench #234

Closed
davros85 opened this Issue Oct 12, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@davros85

davros85 commented Oct 12, 2016

Thank you for reporting an issue or suggesting an enhancement. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you.

Category

  • Question
  • Typo
  • Bug
  • Enhancement / Suggestion
  • Additional article idea

Expected or Desired Behavior

When running a web part using the knockout template in the SharePoint workbench, it renders the web part.

Observed Behavior

When stepping through the code on init, the web part renders initially, below the loading spinner. Then in the _internalFirstTimeRender method, when this.context.statusRenderer.clearLoadingIndicator(this.domElement) is called, the web part disappears - it is cleaned from the DOM.

I have noticed a difference between the local workbench and SharePoint workbench - 'this.domElement' in the SP workbench contains a '.placeholder' element, whereas in the local workbench it does not.

Steps to Reproduce

Yo a new knockout webpart, (fix the _description bug, and remove all custom properties). Run the web part in the workbench in SharePoint.

@manishgarg1

This comment has been minimized.

manishgarg1 commented Oct 12, 2016

I know of this problem. Looking at fixing soon.

@davros85

This comment has been minimized.

davros85 commented Oct 14, 2016

Workaround presented as part of #233

@manishgarg1

This comment has been minimized.

manishgarg1 commented Jan 25, 2017

This is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment