New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"teams" folder is missing when project is created in a subfolder with 1.7.1 --plusbeta #3423

Open
vman opened this Issue Feb 8, 2019 · 8 comments

Comments

Projects
None yet
4 participants
@vman
Copy link
Contributor

vman commented Feb 8, 2019

Category

  • Question
  • Typo
  • Bug
  • Additional article idea

Expected or Desired Behavior

When default scaffolding is created with the 1.7.1 --plusbeta version of the generator and select "Create a subfolder", the "teams" folder should be present as described in this article:
https://docs.microsoft.com/en-us/sharepoint/dev/spfx/web-parts/get-started/using-web-part-as-ms-teams-tab

Observed Behavior

If you create the scaffolding with 1.7.1 --plusbeta, and select "Create a subfolder" the "teams" folder is absent.

Steps to Reproduce

  1. Make sure SPFx v1.7.1 is installed
  2. yo @microsoft/sharepoint --plusbeta --skip-install
  3. During the initial setup wizart, select "Create a subfolder"
  4. Observe that the teams folder is absent
@msft-github-bot

This comment has been minimized.

Copy link
Collaborator

msft-github-bot commented Feb 8, 2019

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@andrewconnell

This comment has been minimized.

Copy link
Collaborator

andrewconnell commented Feb 10, 2019

What's your installed environment look like (Node, NPM, Yeoman versions)? Just did the same with v1.7.1 and it is present... so I can't repro...

image

There was an issue with v1.7.0 where it was adding the teams subfolder all the time, regardless if you used --plusbeta or not. The v1.7.1 fixed this so it should only appear when you include the beta flag.

@vman

This comment has been minimized.

Copy link
Contributor Author

vman commented Feb 10, 2019

Here is my environment:

image

I noticed you are on a mac and I am on windows. I don't have a mac handy to test if that's the difference?

And for comparison, I downgraded to v1.7.0 and ran the generator with --plusbeta again:

image

@andrewconnell

This comment has been minimized.

Copy link
Collaborator

andrewconnell commented Feb 11, 2019

It's not a Mac / Windows thing... I have the same expected behavior on Windows:

image

So it's something else local to your machine I think... still can't repro your experience...

BTW... as I said in my last post, you will always see the teams folder get created in v1.7.0 because of a bug in the generator. Regardless of the presence of the --plusbeta switch, the v1.7.0 generator will ALWAYS add that folder. v1.7.1 fixed this behavior so you only see it when adding the flag.

@vman

This comment has been minimized.

Copy link
Contributor Author

vman commented Feb 11, 2019

Thanks for your help on this @andrewconnell! I think I know whats wrong. The teams folder is missing when I select "Create a subfolder" in the initial wizard. I also don't get the question which determines the isDomainIsolated setting
image

However, if I select "Use the current folder", I get the teams folder as well as the isDomainIsolated question:
image

Are you able to reproduce this?

@vman vman changed the title "teams" folder is missing when project is created with 1.7.1 --plusbeta "teams" folder is missing when project is created in a subfolder with 1.7.1 --plusbeta Feb 11, 2019

@andrewconnell

This comment has been minimized.

Copy link
Collaborator

andrewconnell commented Feb 11, 2019

Good find... yes, I can confirm that when you select "create a subfolder with a solution name", it's like the --plusbeta is not respected. Will raise this with engineering too...

@vman

This comment has been minimized.

Copy link
Contributor Author

vman commented Feb 11, 2019

Although the package.json does have all the 1.7.1-plusbeta versions of the SPFx packages. That's what I used to confirm that I wasn't going mad and was indeed using the --plusbeta flag.

@VesaJuvonen

This comment has been minimized.

Copy link
Contributor

VesaJuvonen commented Feb 11, 2019

Clearly a bug, which we'll be checking to fix for the 1.8 release. Thx @vman for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment