Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React types using an old version in SPFx 1.8.0 #3605

Open
estruyf opened this Issue Mar 14, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@estruyf
Copy link
Contributor

estruyf commented Mar 14, 2019

Category

  • Question
  • Typo
  • Bug
  • Additional article idea

Expected or Desired Behavior

@patmill in the latest version of SPFx, the version of React got bumped to 16.7 which is a great thing, but the types are still referencing the same version as in 1.7.0 and 1.7.1: "@types/react": "16.4.2". Due to this, you are not able to use any of the new features in React version 16.7.

@msft-github-bot

This comment has been minimized.

Copy link
Collaborator

msft-github-bot commented Mar 14, 2019

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@patmill

This comment has been minimized.

Copy link
Contributor

patmill commented Mar 14, 2019

OK, thanks. We can certainly bump that and push an update. Is there any issue when you manually bump the version and re-install/rebuild?

@estruyf

This comment has been minimized.

Copy link
Contributor Author

estruyf commented Mar 14, 2019

@patmill check: https://www.eliostruyf.com/using-the-full-potential-of-react-in-sharepoint-framework-1-8-0/

In order to manually bump the types version, the TypeScript version also needs to be updated to version 3.2.

@patmill

This comment has been minimized.

Copy link
Contributor

patmill commented Mar 14, 2019

When you go down that rabbit hole, what version of OUIFR do you use? (or do you?)

@estruyf

This comment has been minimized.

Copy link
Contributor Author

estruyf commented Mar 15, 2019

The same version that is part of SPFx, so in this case it will be 6.143.0. Although I have not yet tested it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.