Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync to Teams ribbon button is not working #3619

Open
kchiragowni opened this Issue Mar 17, 2019 · 6 comments

Comments

Projects
None yet
7 participants
@kchiragowni
Copy link

kchiragowni commented Mar 17, 2019

Category

  • Question
  • Typo
  • Bug
  • Additional article idea

Expected or Desired Behavior

SharePoint Framework Webpart with 'TeamsTab' supported host added to webpart manifest file deployed to AppCatalog site collection.

"supportedHosts": ["SharePointWebPart", "SharePointFullPage", "TeamsTab"]

Selecting the webpart enabled 'Sync to Teams' ribbon button, clicking the button should deployed the SPFx webpart automatically to Teams.

Observed Behavior

Clicking the 'Sync to Teams' button nothing happens and SPFx webpart not deployed to Teams.

Steps to Reproduce

  1. Create a standard SPFx webpart
  2. Updated Webpart manifest to inculde 'TeamsTab' in Supported Hosts array 'supportedHosts'
  3. Bundle, Package solution and add & deploy to App catalog
  4. Select the webpart to enable 'Sync to Teams' ribbon button
  5. Click the 'Sync to Teams' button to deploy webparts to team.
@msft-github-bot

This comment has been minimized.

Copy link
Collaborator

msft-github-bot commented Mar 17, 2019

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@PooLP

This comment has been minimized.

Copy link

PooLP commented Mar 17, 2019

Same for me, after click, nothing happens (no loader, message, error ...)

@etesson

This comment has been minimized.

Copy link

etesson commented Mar 22, 2019

I have the same issue. A small toast popup on the right displaying "Failed to sync solution to teams".

image

@AJIXuMuK

This comment has been minimized.

Copy link
Contributor

AJIXuMuK commented Mar 29, 2019

First time I clicked it I received response {"d":{"SyncSolutionToTeams":null}}.
The app is not visible in Teams app catalog.

I tried to click the button again - and now I'm getting 409:

{"error":{"code":"-1, System.Net.WebException","message":{"lang":"en-US","value":"The remote server returned an error: (409) Conflict."}}}

UPD:
I see the app if I run https://graph.microsoft.com/v1.0/appCatalogs/teamsApps but still can't find it in UI and unable to add to a team

UPD2:
I'm able to install the app to the team using MS Graph POST https://graph.microsoft.com/v1.0/teams/{team-id}/installedApps

But the app is still invisible in UI.
OK, I've tried to add a tab using MS Graph as well:

POST https://graph.microsoft.com/v1.0/teams/11afb149-c7db-48d8-b84d-7103cf8a7372/channels/19:5ede4467bdac4d409efeaa3afe0bd6a3@thread.skype/tabs

{
  "displayName": "Team Papers",
  "teamsApp@odata.bind": "https://graph.microsoft.com/v1.0/appCatalogs/teamsApps/35f008ad-927a-4c5a-ac5e-714a3b96972c"
}

Response:

Satus Code: 201

{
    "@odata.context": "https://graph.microsoft.com/v1.0/$metadata#teams('11afb149-c7db-48d8-b84d-7103cf8a7372')/channels('19%3A5ede4467bdac4d409efeaa3afe0bd6a3%40thread.skype')/tabs/$entity",
    "id": "777f1bb6-a7ac-43c8-847f-76b4c6c956c5",
    "displayName": "Team Papers",
    "webUrl": "https://teams.microsoft.com/l/channel/19%3a5ede4467bdac4d409efeaa3afe0bd6a3%40thread.skype/tab%3a%3afd3f754d-ea46-4c9c-8a02-eb5e2810604e?label=Team+Papers&groupId=11afb149-c7db-48d8-b84d-7103cf8a7372&tenantId=15d095b1-76f0-493f-8cd4-114a12013570",
    "configuration": {
        "entityId": null,
        "contentUrl": null,
        "removeUrl": null,
        "websiteUrl": null
    }
}

But no tab visible...
If you request tabs for the channel using MS Graph... the tab is there :)
Once I also got a response that the app is in "blocked" state or something.

UPD3:
It's absolutely unstable.
Now I can't get the app using MS Graph, but if I click "Sync To Teams" I still receive 409.

@juliemturner

This comment has been minimized.

Copy link
Contributor

juliemturner commented Apr 4, 2019

I'm having a related issue, with an upgraded solution not a new one. I get the same UX error message as @etesson:

  • Updated solution to 1.8
  • Got the solution deployed and it's working correctly
  • Tried "Sync to teams" got failure message... look at browser console. Call to https://{site}.sharepoint.com/sites/AppCatalog/_api/web/tenantappcatalog/SyncSolutionToTeams return 500 error, error payload: {"error":{"code":"-2146232832, Microsoft.SharePoint.AppPackageValidationException","message":{"lang":"en-US","value":"Package does not contain required images"}}}
  • Realized I still had the manifest file in teams folder, removed it, rebuild, deploy, click "Sync to teams" -- same message
  • Realized that a new project has different default image names (wondered if it were hard coded or something) -- copied images from new project to old project... still same message.
  • Created brand new project, starting with 1.8 generator and it worked fine.

UPD1:
By making sure my image files were named with the component id I was able to get the sync step to work without error. However, even though the "Sync to teams" button (and corresponding http call) completes successfully I'm not in the same spot that @AJIXuMuK is in where I can see that the app is in the Teams app catalog but I cannot see it in the Teams UI. I've tried deploying in 2 different tenants with the same result. I've also tried creating the manifest file per the updated documentation and have the same result. However, unlike @AJIXuMuK I was going to attempt to manually add the app to the team to see if I had success, but got an error message when I tried:

https://graph.microsoft.com/v1.0/teams/{team-id}/installedApps

Status Code: 500
{ "error": { "code": "GeneralException", "message": "Input string '----------------------------223732734073719083656464' is not a valid number. Path '', line 1, position 52.", "innerError": { "request-id": "c4998a3f-abe4-4e64-8486-0c3cef7c377a", "date": "2019-04-05T15:17:13" } } }

UPD2:
At this point I feel like I have it working fine. Without any changes (since update 1) it's now appearing in the teams desktop client as well as the web client.

@VesaJuvonen

This comment has been minimized.

Copy link
Contributor

VesaJuvonen commented Apr 18, 2019

Hi @kchiragowni, can you update on the status for this. Are you still seeing this? It should be already fixed, so would love to get a confirmation on the status. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.