Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPO Hosted Workbench.aspx fails to load gulp-serve'd code #4350

Closed
AJIXuMuK opened this issue Jul 24, 2019 · 16 comments

Comments

@AJIXuMuK
Copy link
Contributor

commented Jul 24, 2019

Category

  • Question
  • Typo
  • Bug
  • Additional article idea

Expected or Desired Behavior

Workbench.aspx loads manifests.js using HTTPS

Observed Behavior

Screen Shot 2019-07-23 at 5 27 05 PM

Screen Shot 2019-07-23 at 5 27 19 PM

Steps to Reproduce

  1. Create new web part (I'm using SPFx 1.9.0)
  2. gulp serve --nobrowser
  3. open layouts/15/workbench.aspx
@msft-github-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 24, 2019

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@AJIXuMuK

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

More details:
It looks like it tries to load the file twice.
First time using https and it is actually loaded.
But there there is some error and second request with http.

Screen Shot 2019-07-23 at 5 34 50 PM

Screen Shot 2019-07-23 at 5 36 14 PM

@AJIXuMuK

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

Setting "https": false in serve.json doesn't help.

@martinlingstuyl

This comment has been minimized.

Copy link

commented Jul 24, 2019

Same here... I'm back to re-installing 1.8.2 on my project

@mmohamedbasith

This comment has been minimized.

Copy link

commented Jul 24, 2019

i am facing the same issue . @VesaJuvonen can you help to resolve this issue?

@FAT77

This comment has been minimized.

Copy link

commented Jul 24, 2019

Same problem. Since upgrade to 1.9.0 hosted workbench stopped working.

@jcosta33

This comment has been minimized.

Copy link

commented Jul 24, 2019

Same problem with extensions (on 1.9.0)...

@patmill

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

Weird - I can't seem to repro this - but it is clearly affecting you. The double fetch has normally been there (legacy from V1.0).

If someone has this failing on a test tenant, and doesn't mind creating / sharing credentials with me, I can take a closer look. Otherwise I'll need to check with others. patmill at microsoft.com is my email.

Alternately, could someone post a screen shot of the network tab showing the calls?

@patmill

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

Also - what does the command prompt look like when gulp is running? What files are being requested, etc.

And does your project do anything with webpack plug ins, etc? Does a plain hello world , no framework project work?

@mmohamedbasith

This comment has been minimized.

Copy link

commented Jul 24, 2019

@patmill i can confirm that I tried with react hello world project (without adding any addition code). The issue occurred. i dont have screenshot now any as i have reverted my SPFX back to 1.8.2 again after a long day of struggle with 1.9.0 version

@patmill

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

OK, I have found a tenant where this repros, and the same project, same code, succeeds in another tenant. They are both running the same production code as well. So on the plus side, at first glance this looks like a problem on our servers, not with the npm bits. Stay tuned.

@AmonReviled

This comment has been minimized.

Copy link

commented Jul 24, 2019

@patmill Yes, the issue occurs with a plain, no-framework project.
image
image
image
image

@patmill patmill changed the title SPO Hosted Workbench.aspx is trying to load manifests.js using http SPO Hosted Workbench.aspx fails to load gulp-serve'd code Jul 24, 2019

@patmill

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

Yeah, so the errors in manifests.js are a red herring. The problem is that ultimately the parsing/js loading of manifests.js doesn't happen in the error case, because the script element doesn't wind up in the DOM. Digging in further.

@patmill

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

OK - so we have found the problem, and have a solution. We need to figure out the best way to publish it. There was a change in how the local manifests.js file is built, and it caused an issue on the hosted workbench.

Unfortunately, our release process winds up using a codepath that bypassed this error. We've updated the steps to ensure this doesn't happen again. Will post here when we have next steps.

@olemp

This comment has been minimized.

Copy link

commented Jul 25, 2019

Experiencing the same issues. Both with http and https.

@andrewconnell

This comment has been minimized.

Copy link
Collaborator

commented Jul 29, 2019

Appears the temp "fix" was to pull v1.9.0... so for now, this is "fixed" as there were known issues with 1.9.0 & hosted workbench. Ref #4371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
10 participants
You can’t perform that action at this time.