New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build pipeline with Webpack 2? #529

Closed
s-KaiNet opened this Issue Mar 31, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@s-KaiNet
Contributor

s-KaiNet commented Mar 31, 2017

Category

  • Question
  • Typo
  • Bug
  • Enhancement / Suggestion
  • Additional article idea

Are there any news about upgrading spfx build pipeline to webpack 2?

Webpack 1 is officially deprecated. Many folks upgraded and use webpack 2 on different projects.

When working with spfx sometimes you need to add additional webpack loader or to do any other fine tuning for webpack task. It will be much more convenient to do that with webpack 2, because this is current version of webpack, no need to switch "context" back to webpack 1, also the schema for webpack 2 is much more understandable.
One another caveat with webpack 1 that some loaders don't guarantee backward compatibility with webpack 1.

Taking all this into account I really would like to see webpack 2 in the build pipeline.

@jonathanhotono

This comment has been minimized.

Show comment
Hide comment
@jonathanhotono

jonathanhotono Apr 2, 2017

I definitely look forward for webpack to be updated. Plus sass will need to support sourcemap by default so on dev mode it doesn't reference it straight to <style> but instead the scss file.

jonathanhotono commented Apr 2, 2017

I definitely look forward for webpack to be updated. Plus sass will need to support sourcemap by default so on dev mode it doesn't reference it straight to <style> but instead the scss file.

@nickpape-msft

This comment has been minimized.

Show comment
Hide comment
@nickpape-msft

nickpape-msft Jun 5, 2017

Contributor

Hi @s-KaiNet, we have upgraded to Webpack 2.0 and this will be in the next release. @iclanton can comment more.

Contributor

nickpape-msft commented Jun 5, 2017

Hi @s-KaiNet, we have upgraded to Webpack 2.0 and this will be in the next release. @iclanton can comment more.

@jonathanhotono

This comment has been minimized.

Show comment
Hide comment
@jonathanhotono

jonathanhotono Jun 6, 2017

@nickpape-msft do we have the sass sourcemaps enabled as well on the next release?

jonathanhotono commented Jun 6, 2017

@nickpape-msft do we have the sass sourcemaps enabled as well on the next release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment