New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃檹 Extensions: Application Customizer - Additional Placeholders Requested #625

Closed
andrewconnell opened this Issue Jun 8, 2017 · 12 comments

Comments

Projects
None yet
9 participants
@andrewconnell
Collaborator

andrewconnell commented Jun 8, 2017

Category

  • Question
  • Typo
  • Bug
  • Additional article idea

Today we get PageHead & PageFooter... would like to have BEFORE/AFTER DIV's for QuickLaunch & PlaceHolderMain

If you are planning to share a new feature request (enhancement / suggestion), please use SP Dev UserVoice at http://aka.ms/sp-dev-uservoice.

OK... cross-referenced:
https://sharepoint.uservoice.com/forums/329220-sharepoint-dev-platform/suggestions/19536022-extensions-application-customizer-additional-pl

@VesaJuvonen

This comment has been minimized.

Show comment
Hide comment
@VesaJuvonen

VesaJuvonen Jun 8, 2017

Contributor

Thx AC for the input.
We'll absolutely introduce additional placeholders for the framework and this is a good input for getting the needed placeholders tracked. We would also love to have some details around the actual scenarios where you'd use the requested capabilities. That might be obvious in some cases, but actual business scenarios and use cases help to prioritize the requests. Thx.

Contributor

VesaJuvonen commented Jun 8, 2017

Thx AC for the input.
We'll absolutely introduce additional placeholders for the framework and this is a good input for getting the needed placeholders tracked. We would also love to have some details around the actual scenarios where you'd use the requested capabilities. That might be obvious in some cases, but actual business scenarios and use cases help to prioritize the requests. Thx.

@patmill

This comment has been minimized.

Show comment
Hide comment
@patmill

patmill Jun 8, 2017

Contributor

Cross posting my response from UV.

Hey AC - While I know what you mean here, can you refine this to target the modern experiences? For example, PlaceholderMain is an asp.net masterpage div that doesn't exist in the newer code. Would you think of Pre/Post Placeholdermain to be ContentHeader and ContentFooter (as opposed to PageHeader and PageFooter?

Additionally, how would you expect scrolling to work in this scenario? For example - what should happen with a listview with infinite scroll vs. a page with 500k of text?

Contributor

patmill commented Jun 8, 2017

Cross posting my response from UV.

Hey AC - While I know what you mean here, can you refine this to target the modern experiences? For example, PlaceholderMain is an asp.net masterpage div that doesn't exist in the newer code. Would you think of Pre/Post Placeholdermain to be ContentHeader and ContentFooter (as opposed to PageHeader and PageFooter?

Additionally, how would you expect scrolling to work in this scenario? For example - what should happen with a listview with infinite scroll vs. a page with 500k of text?

@andrewconnell

This comment has been minimized.

Show comment
Hide comment
@andrewconnell

andrewconnell Jun 8, 2017

Collaborator

@patmill Will xpost from UV too :)
Specifically looking for any place these extensions are supported... if that's just modern experiences, then just those (although I hope these will also apply to classic pages, just as client-side web parts do). Understand the names are different... I was referring to the intent of where things would go... a picture might help. I see the RED is what you provide today... the GREEN is what I'm asking for:

image

As for infinite scroll... I'd expect it to behave like the components that wrap them. For instance, on the QuickLaunch, it doesn't scroll so I'd expect what I put right after it to be pinned to the bottom border of the QL. Same is true with the main body of the page.

@VesaJuvonen - Biz case: context help, messages to the user based on the context of what they are doing or reminders they haven't done something. I could do this by doing DOM manipulation from the header / footer, and that's what folks will do as these are common places we want to add / remove stuff... but that's now how we should be doing it... so don't give them a reason to do it and add it for them. Make sense?

Collaborator

andrewconnell commented Jun 8, 2017

@patmill Will xpost from UV too :)
Specifically looking for any place these extensions are supported... if that's just modern experiences, then just those (although I hope these will also apply to classic pages, just as client-side web parts do). Understand the names are different... I was referring to the intent of where things would go... a picture might help. I see the RED is what you provide today... the GREEN is what I'm asking for:

image

As for infinite scroll... I'd expect it to behave like the components that wrap them. For instance, on the QuickLaunch, it doesn't scroll so I'd expect what I put right after it to be pinned to the bottom border of the QL. Same is true with the main body of the page.

@VesaJuvonen - Biz case: context help, messages to the user based on the context of what they are doing or reminders they haven't done something. I could do this by doing DOM manipulation from the header / footer, and that's what folks will do as these are common places we want to add / remove stuff... but that's now how we should be doing it... so don't give them a reason to do it and add it for them. Make sense?

@PopWarner

This comment has been minimized.

Show comment
Hide comment
@PopWarner

PopWarner Jun 8, 2017

I agree with AC. While @VesaJuvonen has mentioned that keeping our customization's within the confines of these placeholders, which I assume is the contractual safe place for custom content, ensures that it will not get destroyed or broken with future updates to the DOM, if there are not additional Placeholders to be populated, users will simply begin manipulating the DOM.

While this isn't how they should add customization's, as @andrewconnell as mentioned, if there are no other places, peeps will still do it.

The Pre/Post locations could also provide the ability to wrap that content with a custom CSS classname for ensuring specificity within a certain brand/design.....just one possible other thought.

PopWarner commented Jun 8, 2017

I agree with AC. While @VesaJuvonen has mentioned that keeping our customization's within the confines of these placeholders, which I assume is the contractual safe place for custom content, ensures that it will not get destroyed or broken with future updates to the DOM, if there are not additional Placeholders to be populated, users will simply begin manipulating the DOM.

While this isn't how they should add customization's, as @andrewconnell as mentioned, if there are no other places, peeps will still do it.

The Pre/Post locations could also provide the ability to wrap that content with a custom CSS classname for ensuring specificity within a certain brand/design.....just one possible other thought.

@andrewconnell andrewconnell changed the title from Extensions: Application Customizer - Additional Placeholders Requested to 馃檹 Extensions: Application Customizer - Additional Placeholders Requested Jul 7, 2017

@SPParseError

This comment has been minimized.

Show comment
Hide comment
@SPParseError

SPParseError Jul 19, 2017

Adding some additional placeholder requests here, as discussed in #656

  1. Site metadata: custom site meta data (state, contacts, project duration...)
  2. Search bar: custom search bar
  3. Left navigation: having a global navigation, buttons to create documents from templates, showing company's applications...

placeholders

SPParseError commented Jul 19, 2017

Adding some additional placeholder requests here, as discussed in #656

  1. Site metadata: custom site meta data (state, contacts, project duration...)
  2. Search bar: custom search bar
  3. Left navigation: having a global navigation, buttons to create documents from templates, showing company's applications...

placeholders

@lucaband

This comment has been minimized.

Show comment
Hide comment
@lucaband

lucaband Aug 17, 2017

Contributor

To updated everyone on this topic: the scenario is well understood and we are working to be sure we tackle that properly. There's still an open conversation to understand if Placeholders is the right technology to use to enable such scenarios or it is something else.

Contributor

lucaband commented Aug 17, 2017

To updated everyone on this topic: the scenario is well understood and we are working to be sure we tackle that properly. There's still an open conversation to understand if Placeholders is the right technology to use to enable such scenarios or it is something else.

@lucaband lucaband closed this Aug 17, 2017

@andrewconnell

This comment has been minimized.

Show comment
Hide comment
@andrewconnell

andrewconnell Aug 18, 2017

Collaborator

I'm confused @lucaband ... why close the issue if the conversation is still open even if internally?

Collaborator

andrewconnell commented Aug 18, 2017

I'm confused @lucaband ... why close the issue if the conversation is still open even if internally?

@lucaband

This comment has been minimized.

Show comment
Hide comment
@lucaband

lucaband Aug 18, 2017

Contributor

Andrew, thanks,
Reason why I closed was because I though I answered the initial question.
But I'm perfectly fine to keep it open, assign it to me, and reply back here once we have some concrete news.

Contributor

lucaband commented Aug 18, 2017

Andrew, thanks,
Reason why I closed was because I though I answered the initial question.
But I'm perfectly fine to keep it open, assign it to me, and reply back here once we have some concrete news.

@lucaband lucaband reopened this Aug 18, 2017

@saendu

This comment has been minimized.

Show comment
Hide comment
@saendu

saendu Oct 4, 2017

This might be interessting for you as well: https://sharepoint.uservoice.com/forums/329220-sharepoint-dev-platform/suggestions/31752808-extensions-property-pane-sidebar-placeholder-r
I would like to see a sidebar placeholder on the right side.

saendu commented Oct 4, 2017

This might be interessting for you as well: https://sharepoint.uservoice.com/forums/329220-sharepoint-dev-platform/suggestions/31752808-extensions-property-pane-sidebar-placeholder-r
I would like to see a sidebar placeholder on the right side.

@nsksaisaravana

This comment has been minimized.

Show comment
Hide comment
@nsksaisaravana

nsksaisaravana Mar 8, 2018

I would like to achieve the below-highlighted stuff in the modern experience but it is not possible due to the limited number of placeholders. Please introduce more placeholders as requested.

image

nsksaisaravana commented Mar 8, 2018

I would like to achieve the below-highlighted stuff in the modern experience but it is not possible due to the limited number of placeholders. Please introduce more placeholders as requested.

image

@mpowney

This comment has been minimized.

Show comment
Hide comment
@mpowney

mpowney Mar 19, 2018

@lucaband Are there any updates on a solution to this issue?

mpowney commented Mar 19, 2018

@lucaband Are there any updates on a solution to this issue?

@VesaJuvonen

This comment has been minimized.

Show comment
Hide comment
@VesaJuvonen

VesaJuvonen Mar 20, 2018

Contributor

as this is a new feature request and not specifically an issue, we'll close this, for now, to help on tracking actual issues in the issue list (trying to drive new feature requests to UserVoice). We will have some announcements coming up around this area during this spring - SPC18 and later.

Contributor

VesaJuvonen commented Mar 20, 2018

as this is a new feature request and not specifically an issue, we'll close this, for now, to help on tracking actual issues in the issue list (trying to drive new feature requests to UserVoice). We will have some announcements coming up around this area during this spring - SPC18 and later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment