New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悶 Loading indicator not showing in any in base DOMElement #696

Closed
andrewconnell opened this Issue Jul 5, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@andrewconnell
Collaborator

andrewconnell commented Jul 5, 2017

Category

  • Question
  • Typo
  • Bug
  • Additional article idea

Expected or Desired Behavior

All samples using the loading indicator show it being added to the this.DOMElement, then using a timeout to remove it within a web part's render() method.

Observed Behavior

The loading indicator isn't showing in the local or SPO hosted workbench.

The only way I was able to get it to appear was to add an element within the DOMElement, then put the loading indicator in that... similar to how this post does it.

It appears nothing is being added to the this.DOMElement when the loading indicator is added.

Steps to Reproduce

Look at this sample within your own training materials linked below. It should show the loading animation for 2s, then an error for 2s, then clear and show a web part. The first step (the loading animation) never renders.

https://github.com/OfficeDev/TrainingContent/tree/master/SharePoint/SharePointFramework/02%20Deep%20Dive%20of%20the%20SharePoint%20Framework/Demos/helloworld-webpart

@andrewconnell andrewconnell changed the title from Loading indicator not showing in any in base DOMElement to 馃敟 Loading indicator not showing in any in base DOMElement Jul 7, 2017

@andrewconnell andrewconnell changed the title from 馃敟 Loading indicator not showing in any in base DOMElement to 馃悶 Loading indicator not showing in any in base DOMElement Jul 7, 2017

@chackman

This comment has been minimized.

Show comment
Hide comment
@chackman

chackman Jul 10, 2017

Contributor

Thanks for your feedback; we're investigating this issue.

Contributor

chackman commented Jul 10, 2017

Thanks for your feedback; we're investigating this issue.

@chackman

This comment has been minimized.

Show comment
Hide comment
@chackman

chackman Jul 25, 2017

Contributor

The issue should be fixed and will be rolling out in an upcoming build. If it's not fixed within the next week, please open a new bug. Thanks!

Contributor

chackman commented Jul 25, 2017

The issue should be fixed and will be rolling out in an upcoming build. If it's not fixed within the next week, please open a new bug. Thanks!

@chackman chackman closed this Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment