Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🙏 SPFx - Please upgrade React to modern [and supported] version of React (ideally v18, but at least v17) #8265

Closed
1 of 9 tasks
andrewconnell opened this issue Jul 2, 2022 · 13 comments
Labels
area:spfx Category: SharePoint Framework (not extensions related) status:tracked Currently tracked with Microsoft’s internal issue tracking system. DO NOT ADD/REMOVE (MSFT managed)
Milestone

Comments

@andrewconnell
Copy link
Collaborator

What type of issue is this?

Question

What SharePoint development model, framework, SDK or API is this about?

💥 SharePoint Framework

Target SharePoint environment

SharePoint Online

What browser(s) / client(s) have you tested

  • 💥 Internet Explorer
  • 💥 Microsoft Edge
  • 💥 Google Chrome
  • 💥 FireFox
  • 💥 Safari
  • mobile (iOS/iPadOS)
  • mobile (Android)
  • not applicable
  • other (enter in the "Additional environment details" area below)

Additional environment details

  • SPFx v1.15
  • Node.js v16

Issue description

The current version of React in new SPFx v1.15 projects is React v16. That version was released FOUR years ago (April 2018). Since then, there have been two major releases of React... v17 (nearly 2 years ago, October 2020) & v18 (current).

You can't even get the docs for the React v16 version from the React docs anymore.

PLEASE upgrade to a more modern version of React. While I understand you can't run two versions of React on the same page without a LOT of gymnastics, even though SPO uses React v16, it's outdated and not supported.

@ghost
Copy link

ghost commented Jul 2, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 Awaiting categorization and initial review. label Jul 2, 2022
@andrewconnell andrewconnell changed the title 🙏 SPFx - Please upgrade to modern [and supported] version of React (ideally v18, but at least v17) 🙏 SPFx - Please upgrade React to modern [and supported] version of React (ideally v18, but at least v17) Jul 2, 2022
@PooLP
Copy link

PooLP commented Jul 4, 2022

Hi,
You are right. I asked the question a few months ago, but no precise date (in 2 or 3 years, as usual :D)
#7864

@VesaJuvonen VesaJuvonen added area:spfx Category: SharePoint Framework (not extensions related) and removed Needs: Triage 🔍 Awaiting categorization and initial review. labels Jul 4, 2022
@hesperanca
Copy link

+1 of this request. It would be great to see an upgrade on the version of React.

@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Jul 5, 2022

Thanks @andrewconnell for bringing this up!
We have some internal dependencies that slow down this kind of upgrade.
But we're actively working on it.

Hope to have some updates during this CY, definitely not in 2-3 years :)

@AJIXuMuK AJIXuMuK closed this as completed Jul 5, 2022
@andrewconnell
Copy link
Collaborator Author

If you’re actively working on it, then why was this issue closed?

@andrewconnell andrewconnell reopened this Jul 6, 2022
@ryanjfarrell
Copy link

This would be huge. Is there any way you could make the fact that you are working on it transparent in the roadmap? Perhaps even an overview of the challenges involved and how the community might help to move things along?

There are many react related npm packages that have their latest version dependant on a more current version of React.

@SiemvandenBerg
Copy link

+1 to making this transparent on the roadmap. This way we can orchestrate other changes we need to make for this important upgrade. The good thing is, when after you have upgraded, React is supposed to be backward compatible, hopefully reducing the upgrade demands in the future :)

@AJIXuMuK AJIXuMuK added the status:tracked Currently tracked with Microsoft’s internal issue tracking system. DO NOT ADD/REMOVE (MSFT managed) label Jul 20, 2022
@AJIXuMuK
Copy link
Collaborator

@ryanjfarrell - we can include that in Roadmap.
I'd expect this change in SPFx 1.16 or 1.17 (both of those should be release by end of 2022).

@ryanjfarrell
Copy link

Thanks, @AJIXuMuK !

@jrdavismaine
Copy link

@ryanjfarrell - we can include that in Roadmap. I'd expect this change in SPFx 1.16 or 1.17 (both of those should be release by end of 2022).

Looks like React is still version 16.13.1 with 1.16.0-beta.1. Hoping to see the upgrade in version 1.17.

  "dependencies": {
    "tslib": "2.3.1",
    "react": "16.13.1",
    "react-dom": "16.13.1",
    "office-ui-fabric-react": "7.192.0",
    "@microsoft/sp-core-library": "1.16.0-beta.1",
    "@microsoft/sp-property-pane": "1.16.0-beta.1",
    "@microsoft/sp-webpart-base": "1.16.0-beta.1",
    "@microsoft/sp-lodash-subset": "1.16.0-beta.1",
    "@microsoft/sp-office-ui-fabric-core": "1.16.0-beta.1"
  },

@andrewconnell
Copy link
Collaborator Author

@jdavis61 see: https://github.com/SharePoint/sp-dev-docs/issues?q=is%3Aissue+is%3Aopen+label%3Areact-17

It's coming... soon...

@AJIXuMuK
Copy link
Collaborator

in the latest beta (1.16.0-beta.2) we've updated React to 17

@AJIXuMuK AJIXuMuK added this to the 1.16.0 milestone Oct 31, 2022
@ghost
Copy link

ghost commented Nov 7, 2022

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues

@ghost ghost locked as resolved and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:spfx Category: SharePoint Framework (not extensions related) status:tracked Currently tracked with Microsoft’s internal issue tracking system. DO NOT ADD/REMOVE (MSFT managed)
Projects
None yet
Development

No branches or pull requests

8 participants