When property pane is in Non-Reactive mode, the validation function should only fire when clicked on "Apply" #91

Open
vman opened this Issue Aug 27, 2016 · 2 comments

Projects

None yet

3 participants

@vman
Contributor
vman commented Aug 27, 2016 edited

Right now, no matter if in reactive or non-reactive mode, the validation function fires after the delay set in in the deferredValidationTime property (or the default 200 ms if the property is not set)

When in non-reactive mode, if the validation function fired only after the user clicked on "Apply", it would save a lot of unnecessary function calls, especially if the validation function is making an HTTP request somewhere (e.g. talking to SharePoint)

function fire

My code for this is located here if it helps:
https://github.com/vman/SPFx-Web-part-property-validator

@patmill
Contributor
patmill commented Sep 2, 2016

This should be fixed in Drop 2

@patmill patmill closed this Sep 2, 2016
@vman
Contributor
vman commented Sep 5, 2016

Looks like the issue is still present in Drop 2. Here is the code I have tried with:
https://github.com/vman/Drop-2-Validations

@chakkaradeep chakkaradeep reopened this Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment