Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate to the "GetTime" function for async #2605
Conversation
This comment has been minimized.
This comment has been minimized.
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/spfx/dynamic-loading.md | View |
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.
VesaJuvonen
merged commit 8582657
into
SharePoint:master
Nov 8, 2018
2 checks passed
OpenPublishing.Build
Validation status: passed
Details
license/cla
All CLA requirements met.
This comment has been minimized.
This comment has been minimized.
|
thx David, appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
PopWarner commentedSep 20, 2018
I might be incorrect, but when I did this with an OOB SPFx solution, whether web part or extension, I had to set my functions as "async" or I wasn't able to use the 'await'. Feel free to disregard if I'm not accurate, but wanted to pass along my experience.
Category
What's in this Pull Request?
Updated the functions that are used to perform the dynamic loading of the packages.
I might be incorrect, but when I did this with an OOB SPFx solution, whether web part or extension, I had to set my functions as "async" or I wasn't able to use the 'await'. Feel free to disregard if I'm not accurate, but wanted to pass along my experience.
Guidance