New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the "GetTime" function for async #2605

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
3 participants
@PopWarner
Contributor

PopWarner commented Sep 20, 2018

I might be incorrect, but when I did this with an OOB SPFx solution, whether web part or extension, I had to set my functions as "async" or I wasn't able to use the 'await'. Feel free to disregard if I'm not accurate, but wanted to pass along my experience.

Category

  • Content fix
  • New article
  • Related issues: fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Updated the functions that are used to perform the dynamic loading of the packages.
I might be incorrect, but when I did this with an OOB SPFx solution, whether web part or extension, I had to set my functions as "async" or I wasn't able to use the 'await'. Feel free to disregard if I'm not accurate, but wanted to pass along my experience.

Guidance

Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.

Please target your PR to 'master' branch. Released documents are in live branch.

(DELETE THIS PARAGRAPH AFTER READING)

Update to the "GetTime" function for async
I might be incorrect, but when I did this with an OOB SPFx solution, whether web part or extension, I had to set my functions as "async" or I wasn't able to use the 'await'. Feel free to disregard if I'm not accurate, but wanted to pass along my experience.
@spdevdocs

This comment has been minimized.

Contributor

spdevdocs commented Sep 20, 2018

Validation status: passed

File Status Preview URL Details
docs/spfx/dynamic-loading.md Succeeded View

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@VesaJuvonen VesaJuvonen merged commit 8582657 into SharePoint:master Nov 8, 2018

2 checks passed

OpenPublishing.Build Validation status: passed
Details
license/cla All CLA requirements met.
@VesaJuvonen

This comment has been minimized.

Contributor

VesaJuvonen commented Nov 8, 2018

thx David, appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment