New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peoplepicker - Move defaultSelectedUsers from ComponentWillMount to ComponentDidUpdate Lifecycle #135

Closed
AsishP opened this Issue Sep 19, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@AsishP
Contributor

AsishP commented Sep 19, 2018

Category

[X] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 1.7.0 ]

If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.

Expected / Desired Behavior / Question

Peoplepicker enhancement to automatically add selected users when the control is loaded.
defaultSelectedUsers should allow preselected users to be set when the control is loaded.

Observed Behavior

defaultSelectedUsers doesn't work for complex edit data forms because the data fetch takes time and the peoplepicker component is loaded by then.
Fix - Move the selectedUsers setup step from ComponentWillMount to ComponentDidMount.
** Mostly I will pick it up soon, but if someone has an urgent requirement of this, please pick it up

@AsishP AsishP changed the title from Move defaultSelectedUsers from ComponentWillMount to ComponentDidMount Lifecycle to Peoplepicker - Move defaultSelectedUsers from ComponentWillMount to ComponentDidMount Lifecycle Sep 19, 2018

@AsishP AsishP changed the title from Peoplepicker - Move defaultSelectedUsers from ComponentWillMount to ComponentDidMount Lifecycle to Peoplepicker - Move defaultSelectedUsers from ComponentWillMount to ComponentDidMount Lifecycle (Enhancement) Sep 21, 2018

@AsishP AsishP changed the title from Peoplepicker - Move defaultSelectedUsers from ComponentWillMount to ComponentDidMount Lifecycle (Enhancement) to Peoplepicker - Move defaultSelectedUsers from ComponentWillMount to ComponentDidUpdate Lifecycle (Enhancement) Sep 22, 2018

@AsishP AsishP changed the title from Peoplepicker - Move defaultSelectedUsers from ComponentWillMount to ComponentDidUpdate Lifecycle (Enhancement) to Peoplepicker - Move defaultSelectedUsers from ComponentWillMount to ComponentDidUpdate Lifecycle Sep 22, 2018

@AsishP

This comment has been minimized.

Contributor

AsishP commented Sep 22, 2018

@estruyf , This is implemented now and have submitted the PR. Please check. If this could be implemented in the latest release, some of my contacts here could use the control without a workaround. Thanks.

@estruyf

This comment has been minimized.

Collaborator

estruyf commented Oct 26, 2018

The PR is merged and will be available in the latest beta version. Follow this guide in order to test out a beta version: https://sharepoint.github.io/sp-dev-fx-controls-react/beta/

@estruyf

This comment has been minimized.

Collaborator

estruyf commented Nov 6, 2018

This is now available in version 1.10.0.

@estruyf estruyf closed this Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment