Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect usage of ms-PeoplePicker class #275

Closed
effectivetom opened this issue Apr 17, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@effectivetom
Copy link

commented Apr 17, 2019

className={`'ms-PeoplePicker' ${this.props.peoplePickerCntrlclassName ? this.props.peoplePickerCntrlclassName : ''}`}

The single quotes around ms-PeoplePicker weren't removed when the className property was changed to use a template literal. This results in them being rendered to the DOM and the class name not being applied correctly.

@effectivetom effectivetom changed the title Incorrect classname Incorrect usage of ms-PeoplePicker class Apr 17, 2019

@estruyf estruyf added this to the 1.13.0 milestone Apr 24, 2019

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented Apr 24, 2019

@effectivetom good find, this will be fixed in the upcoming release.

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented Apr 24, 2019

This is now in the process to be released.

@estruyf estruyf closed this Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.