Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted items not put in recycle bin for ListItemAttachment #291

Closed
ThomasGranheim opened this issue May 3, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@ThomasGranheim
Copy link

commented May 3, 2019

Category

[ x] Enhancement

[ x] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 1.13.0 ]

Expected / Desired Behavior / Question

Attachements should be sent to the recycle bin - since the control states it will!

Observed Behavior

Attached files are not sent to the site collection recycle bin after deleting it from the ListItemAttachement control.

Steps to Reproduce

Try to delete an item from the control - it will not appear in the recycle bin.

Submission Guidelines

Add RecycleObject to the apiUrl the deleteAttachement method in SPService.ts and the attached file will be collected in the recycle bin:
const apiUrl = ${webAbsoluteUrl}/_api/web/lists('${listId}')/items(${itemId})/AttachmentFiles/getByFileName('${encodeURIComponent(fileName)}')/RecycleObject;

Thanks!

@msftbot

This comment has been minimized.

Copy link

commented May 3, 2019

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2019

@ThomasGranheim thank you very much. Feel free to do a PR next time 😄, because you gave the solution in your issue, I have added you to the list of contributors for the 1.13.2 release.

Feel free to test out the latest beta with your change.

Here you can read more information on how you can test out the latest beta version: https://sharepoint.github.io/sp-dev-fx-controls-react/beta/

@estruyf estruyf added this to the 1.13.2 milestone May 17, 2019

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented May 22, 2019

This has just been released in the version 1.13.2.

@estruyf estruyf closed this May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.