New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[People Picker] Allow to set resultsMaximumNumber #148

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@tsekityam
Contributor

tsekityam commented Oct 6, 2018

Too many suggestions may freeze the UI. Limiting the number of suggestions show to user reduces the chances of freezing.

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? mentioned in #143

What's in this Pull Request?

People picker may be freezing if there are too many matchings, such as searching for users that match a in a tenet with thousands of users.

This patch introduces a new property resultsMaximumNumber to limit the max number of suggestions show to user.

@codecov-io

This comment has been minimized.

codecov-io commented Oct 6, 2018

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          10       10           
  Lines         346      346           
  Branches       78       71    -7     
=======================================
  Hits          279      279           
  Misses         44       44           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b54fda7...faf2e90. Read the comment docs.

@estruyf

This comment has been minimized.

Collaborator

estruyf commented Oct 15, 2018

Thanks @tsekityam this got merged to the DEV branch.

@estruyf estruyf closed this Oct 15, 2018

@estruyf estruyf added this to the 1.10.0 milestone Oct 15, 2018

@estruyf estruyf referenced this pull request Nov 5, 2018

Merged

Merge for v1.10.0 release #172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment