New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added defaults to PeoplePicker doc #159

Closed
wants to merge 2 commits into
base: dev
from

Conversation

Projects
None yet
5 participants
@sympmarc

sympmarc commented Oct 23, 2018

Q A
Bug fix? [ ]
New feature? [ ]
New sample? [ ]
Related issues? Docs suggestion

What's in this Pull Request?

Example for displaying defaults for using the PeoplePicker control - issue #158

@msftclas

This comment has been minimized.

msftclas commented Oct 23, 2018

CLA assistant check
All CLA requirements met.

@codecov-io

This comment has been minimized.

codecov-io commented Oct 23, 2018

Codecov Report

Merging #159 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #159   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          10       10           
  Lines         346      346           
  Branches       71       78    +7     
=======================================
  Hits          279      279           
  Misses         44       44           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84fa336...96cf874. Read the comment docs.

@tsekityam

This comment has been minimized.

Contributor

tsekityam commented Oct 25, 2018

@sympmarc ,

There is a new property suggestionsLimit to the picker, which is for limiting the number of suggestions to user. The property is in the dev branch but not yet land on the master branch.

/**
* Maximum number of suggestions to show in the full suggestion list. (default: 5)
*/
suggestionsLimit?: number;

Could you please include the default value of it to your patch?

Thanks,
Kit

@sympmarc

This comment has been minimized.

sympmarc commented Oct 25, 2018

@tsekityam:

Done, but it sort of seems like the doc change should be in your PR so they live together.

M.

@tsekityam

This comment has been minimized.

Contributor

tsekityam commented Oct 26, 2018

It was landed in the dev branch
b93caa5#diff-c193af510d00678280f780917a409152, perhaps you should rebase your branch and you should see the property at the bottom of the table.

@estruyf

This comment has been minimized.

Collaborator

estruyf commented Oct 26, 2018

Thanks @sympmarc this makes things a lot easier indeed. I had to manually do the merge, but it's in.

@estruyf estruyf closed this Oct 26, 2018

@estruyf estruyf added this to the 1.10.0 milestone Oct 26, 2018

@sympmarc

This comment has been minimized.

sympmarc commented Oct 29, 2018

@estruyf If you think adding the defaults the way I did for the PeoplePicker is useful, let me know and I'll try to puzzle out some of the others.

Sorry about the merge difficulties. It was probably because I added the additional default above after the fact.

@estruyf estruyf referenced this pull request Nov 5, 2018

Merged

Merge for v1.10.0 release #172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment