Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field picker list data #165

Merged
merged 5 commits into from Oct 26, 2018

Conversation

Projects
None yet
3 participants
@joaojmendes
Copy link
Contributor

commented Oct 24, 2018

Q A
Bug fix? [ ]
New feature? [ X]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

reusable control using @PnP/PnpJs, Office-ui-fabric-react control, that consist of select value as you type from a list column data. This is util when you have large list of items.

@codecov-io

This comment has been minimized.

Copy link

commented Oct 24, 2018

Codecov Report

Merging #165 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #165   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          10       10           
  Lines         346      346           
  Branches       71       78    +7     
=======================================
  Hits          279      279           
  Misses         44       44           
  Partials       23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84fa336...7be70aa. Read the comment docs.

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented Oct 26, 2018

Thanks @joaojmendes for this PR. Always great to receive new controls. I will align this with the current code base. Would it be possible to also add documentation about how to use this control like you can find here: https://github.com/SharePoint/sp-dev-fx-controls-react/tree/master/docs/documentation/docs/controls/fields - Best to do this in a new PR, that way I can do the code changes.

@estruyf estruyf merged commit 7be70aa into SharePoint:dev Oct 26, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
license/cla All CLA requirements met.
Details
@estruyf

This comment has been minimized.

Copy link
Collaborator

commented Oct 26, 2018

Merge is completed @joaojmendes for this PR. You can check out the changes I did. Once your documentation PR is in, I can release this version soon after it.

estruyf added a commit that referenced this pull request Oct 27, 2018

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented Oct 27, 2018

I did some other changes to the control:

  • Moved them to the controls folder, the fields folder is for Field Customizer extension
  • Replaced the @pnp/pnpjs code with a simple HTTP call. I really like that you used it, but this makes the footprint of the controls bigger. As it was only used for one call, it is much better to have just a simple Rest call to an API.
  • Fixed a bug where you were able to select the item multiple times until the maximum number of items to retrieve was met.

I'm also thinking of renaming the control to ListItemPicker. As that is what the control is providing. What do you think @joaojmendes?

@joaojmendes

This comment has been minimized.

Copy link
Contributor Author

commented Oct 27, 2018

estruyf added a commit that referenced this pull request Oct 28, 2018

@joaojmendes

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2018

@estruyf estruyf referenced this pull request Nov 5, 2018

Merged

Merge for v1.10.0 release #172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.