Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New control List-Item-Attachments #177

Merged
merged 19 commits into from Feb 19, 2019

Conversation

Projects
None yet
3 participants
@joaojmendes
Copy link
Contributor

joaojmendes commented Nov 12, 2018

Q A
Bug fix? [ ]
New feature? [ x ]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

New SPFx Reusable Control, List-Item-Attachments, Manage List Item Attachments in Tile View.

joaojmendes added some commits Nov 6, 2018

Merge pull request #1 from SharePoint/master
update version 1.10
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 12, 2018

Codecov Report

Merging #177 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #177   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          10       10           
  Lines         346      346           
  Branches       71       78    +7     
=======================================
  Hits          279      279           
  Misses         44       44           
  Partials       23       23
Impacted Files Coverage Δ
src/loc/en-us.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a903091...ae6cd6a. Read the comment docs.

@sympmarc sympmarc referenced this pull request Dec 31, 2018

Closed

New Control: Attachments #212

joaojmendes added some commits Feb 7, 2019

Commit changes to SPServices, change @PnP/js to SharePoint API
Commit changes to SPServices, change @PnP/js to SharePoint API
@estruyf

This comment has been minimized.

Copy link
Collaborator

estruyf commented Feb 11, 2019

Thanks @joaojmendes will process it later this week.

@estruyf estruyf merged commit 14254e7 into SharePoint:dev Feb 19, 2019

1 of 2 checks passed

ci/circleci: build Your tests failed on CircleCI
Details
license/cla All CLA requirements met.
Details

estruyf added a commit that referenced this pull request Feb 19, 2019

@estruyf

This comment has been minimized.

Copy link
Collaborator

estruyf commented Feb 19, 2019

@joaojmendes thanks for this PR, it got merged and the control will be available in version 1.12.0. Feel free to test out the beta to see if it is working as you implemented it. I have done some minor code changes for consistency.

@estruyf estruyf added this to the 1.12.0 milestone Feb 19, 2019

@joaojmendes

This comment has been minimized.

Copy link
Contributor Author

joaojmendes commented Feb 21, 2019

thank you very much @estruyf .

@estruyf estruyf referenced this pull request Feb 22, 2019

Merged

Prepare 1.12.0 release #243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.