New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[People Picker] change `titleText` to non-required property #184

Merged
merged 2 commits into from Dec 7, 2018

Conversation

Projects
None yet
3 participants
@tsekityam
Copy link
Contributor

tsekityam commented Nov 16, 2018

Q A
Bug fix? [ ]
New feature? [ ]
New sample? [ ]
Related issues? fixes #175

What's in this Pull Request?

Change titleText to non-required property, and hide the label if titleText is not provide.

estruyf and others added some commits Nov 5, 2018

Merge pull request #172 from SharePoint/dev
Merge for v1.10.0 release
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 16, 2018

Codecov Report

Merging #184 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #184   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          10       10           
  Lines         346      346           
  Branches       71       78    +7     
=======================================
  Hits          279      279           
  Misses         44       44           
  Partials       23       23
Impacted Files Coverage Δ
src/loc/en-us.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a903091...28346f4. Read the comment docs.

@estruyf estruyf merged commit 28346f4 into SharePoint:dev Dec 7, 2018

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
license/cla All CLA requirements met.
Details
@estruyf

This comment has been minimized.

Copy link
Collaborator

estruyf commented Dec 7, 2018

Thank you @tsekityam for this change, your change is now merged and will be available in version 1.11.0.

@tsekityam tsekityam deleted the tsekityam:patch-4 branch Dec 10, 2018

@estruyf estruyf referenced this pull request Dec 21, 2018

Merged

Merge for 1.11.0 #207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment