Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix so that term hierarchy with multiple levels is sorted correctly #217

Closed

Conversation

Projects
None yet
4 participants
@patrikhellgren
Copy link

commented Jan 9, 2019

Q A
Bug fix? [X]
New feature? [ ]
New sample? [ ]
Related issues?

What's in this Pull Request?

Fix so that term hierarchy with multiple levels is sorted correctly, both by name and by custom sort order.
If you before this fix had the following Term Set defined it would not have been displayed correctly in the picker pane:

TestTermSet
  |
  |----1
  |    |
  |    |--1a
  |    |--1b
  |
  |----10
  |    |
  |    |--10a
  |    |--10b
  |
  |----100
  |    |
  |    |--100a
  |    |--100b
@msftclas

This comment has been minimized.

Copy link

commented Jan 9, 2019

CLA assistant check
All CLA requirements met.

@codecov-io

This comment has been minimized.

Copy link

commented Jan 9, 2019

Codecov Report

Merging #217 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #217   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files          16       16           
  Lines         744      744           
  Branches      138      148   +10     
=======================================
  Hits          541      541           
  Misses        159      159           
  Partials       44       44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6985a86...be29d77. Read the comment docs.

@patrikhellgren

This comment has been minimized.

Copy link
Author

commented Jan 9, 2019

If this contribution will be visible among the monthly contributors to PnP, please also include the logo and name of my company. You will find the logo here: https://github.com/SherpasGroup

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented Feb 7, 2019

edit: we might have to do a rewrite of this implementation, as the sort logic got changed a bit to fix issue #229.

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented Feb 7, 2019

Just manually implemented the fix into the service as there were some conflicts. Of what I've seen is that there is only one change required, and that is related to IsRoot check and CustomSortOrderIndex. As the sort logic was changed, don't think we have to implement or do any changes to that anymore.

Feel free to verify the latest beta. I also created an issue for this to track this: #231

@estruyf estruyf added this to the 1.12.0 milestone Feb 19, 2019

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented Feb 19, 2019

Closing this PR as it was manually merged.

@estruyf estruyf closed this Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.