Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress control #230

Merged
merged 6 commits into from Mar 29, 2019

Conversation

Projects
None yet
3 participants
@AJIXuMuK
Copy link
Contributor

commented Feb 2, 2019

Q A
Bug fix? [ ]
New feature? [x]
New sample? [ ]
Related issues? no

What's in this Pull Request?

Progress control shows progress of multiple SEQUENTIALLY executed actions.
The control's implementation is inspired by Site Designs run progress.

progress

@codecov-io

This comment has been minimized.

Copy link

commented Feb 2, 2019

Codecov Report

Merging #230 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #230   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files          16       16           
  Lines         744      744           
  Branches      148      138   -10     
=======================================
  Hits          541      541           
  Misses        159      159           
  Partials       44       44
Impacted Files Coverage Δ
src/loc/en-us.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97818fc...35d3aaf. Read the comment docs.

AJIXuMuK and others added some commits Feb 5, 2019

error icon change; added props to overwrite icons; hasError prioritiz…
…ed on currentIndex - current executing action will be displayed as errored if hasError is set to true - needed for critical errors
Alex Terentiev

@estruyf estruyf merged commit 35d3aaf into SharePoint:dev Mar 29, 2019

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
license/cla All CLA requirements met.
Details

estruyf added a commit that referenced this pull request Mar 29, 2019

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented Mar 29, 2019

thanks @AJIXuMuK this was merged and will be available in version 1.13.0

@estruyf estruyf added this to the 1.13.0 milestone Mar 29, 2019

@estruyf estruyf referenced this pull request Apr 24, 2019

Merged

Merge for 1.13.0 #278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.