Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change person photo url #248

Merged
merged 2 commits into from Mar 29, 2019

Conversation

Projects
None yet
4 participants
@ltdu
Copy link
Contributor

commented Mar 2, 2019

Q A
Bug fix? [ ]
New feature? [ ]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

These controls are used on SharePoint Online as well as on-prem. This commit changes photo URL form Exchange Online to SharePoint endpoint. I chose to use medium image size as this reduces download size, but is still high enough resolution for zoom-in and high-res screens.

@codecov-io

This comment has been minimized.

Copy link

commented Mar 2, 2019

Codecov Report

Merging #248 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #248   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files          16       16           
  Lines         744      744           
  Branches      138      148   +10     
=======================================
  Hits          541      541           
  Misses        159      159           
  Partials       44       44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a3481d...66496cc. Read the comment docs.

@estruyf estruyf merged commit 66496cc into SharePoint:dev Mar 29, 2019

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
license/cla All CLA requirements met.

@estruyf estruyf added this to the 1.13.0 milestone Mar 29, 2019

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented Mar 29, 2019

Thanks @ltdu for this enhancement. This got merged and will be available in version 1.13.0.

@gobigfoot

This comment has been minimized.

Copy link

commented on 6277e44 Apr 22, 2019

Thank you! This fixes issues with Government tenants!

@estruyf estruyf referenced this pull request Apr 24, 2019

Merged

Merge for 1.13.0 #278

@ltdu ltdu deleted the ltdu:people-picker-photo branch Apr 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.