Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculates richtext toolbar top. Fixes #265. #268

Merged
merged 1 commit into from Apr 24, 2019
Merged

Calculates richtext toolbar top. Fixes #265. #268

merged 1 commit into from Apr 24, 2019

Conversation

hugoabernier
Copy link
Contributor

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #265

What's in this Pull Request?

Added code to calculate rich text toolbar position.

@codecov-io
Copy link

Codecov Report

Merging #268 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #268   +/-   ##
=======================================
  Coverage   72.33%   72.33%           
=======================================
  Files          17       17           
  Lines         759      759           
  Branches      146      146           
=======================================
  Hits          549      549           
  Misses        163      163           
  Partials       47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 892b624...bb0c93a. Read the comment docs.

@estruyf estruyf merged commit bb0c93a into pnp:dev Apr 24, 2019
@estruyf
Copy link
Member

estruyf commented Apr 24, 2019

Thanks @hugoabernier, I have successfully merged it.

About the name convention of private variables. I would like to have them without _ as the editors are smart enough. I tend to follow the following rules: https://github.com/Microsoft/TypeScript/wiki/Coding-guidelines. For now I kept it. Will have to write it down so that new components and updates should all be aligned with the same naming conventions.

@estruyf estruyf added this to the 1.13.0 milestone Apr 24, 2019
@hugoabernier
Copy link
Contributor Author

Thanks for pointing this out, I'll update the code when I submit the next update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants