Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iframe dialog commit popup #313

merged 4 commits into from Jul 9, 2019


Copy link

commented May 23, 2019

Bug fix? [ ]
New feature? [x]
New sample? [ ]
Related issues?

What's in this Pull Request?

Very minor update to the IFrameDialogContent component that enables Iframedialog to be correctly closed when the user clicks OK on a SharePoint out of the box pages hosted within the iframe element.
an example is /_layouts/15/SubNew.aspx (popup appears when alert me button is clicked)

estruyf and others added some commits Apr 24, 2019


This comment has been minimized.

Copy link

commented May 23, 2019

Codecov Report

Merging #313 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #313   +/-   ##
  Coverage   72.84%   72.84%           
  Files          17       17           
  Lines         766      766           
  Branches      148      158   +10     
  Hits          558      558           
  Misses        161      161           
  Partials       47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0df446...188f58f. Read the comment docs.


This comment has been minimized.

Copy link

commented Jul 1, 2019

@estruyf not sure if you had a chance to look at this PR


This comment has been minimized.

Copy link

commented Jul 9, 2019

Thanks @ministainer, this will be available in version 1.14.0.

@estruyf estruyf merged commit 66798a1 into SharePoint:dev Jul 9, 2019

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
ci/circleci: test Your tests passed on CircleCI!
license/cla All CLA requirements met.

@estruyf estruyf added this to the 1.14.0 milestone Jul 9, 2019

@estruyf estruyf referenced this pull request Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.