Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onClick and onDblClick should return void, not {} #321

merged 1 commit into from Jul 9, 2019


Copy link

commented Jun 4, 2019

Bug fix? [x]
New feature? [ ]
New sample? [ ]
Related issues? no

What's in this Pull Request?

onClick and onDoubleClick properties were defined incorrectly in some field controls - the return type of these functions should be void instead of {}


This comment has been minimized.

Copy link

commented Jun 4, 2019

Codecov Report

Merging #321 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #321   +/-   ##
  Coverage   72.84%   72.84%           
  Files          17       17           
  Lines         766      766           
  Branches      148      148           
  Hits          558      558           
  Misses        161      161           
  Partials       47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0df446...8ff3a36. Read the comment docs.

@estruyf estruyf merged commit 14c49a2 into SharePoint:dev Jul 9, 2019

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
ci/circleci: test Your tests passed on CircleCI!
license/cla All CLA requirements met.

This comment has been minimized.

Copy link

commented Jul 9, 2019

Thanks @AJIXuMuK

@estruyf estruyf added this to the 1.14.0 milestone Jul 9, 2019

@estruyf estruyf referenced this pull request Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.