Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of the GridLayout control #350

Closed
wants to merge 7 commits into from

Conversation

@hugoabernier
Copy link
Contributor

hugoabernier commented Jul 30, 2019

Q A
Bug fix? [ ]
New feature? [x]
New sample? [ ]
Related issues?
Related pull request #351

What's in this Pull Request?

A GridLayout control to simplify rendering web parts with the standard grid layout. Intended to be really easy to use and handles reflowing content and compact layout.

Sample Grid Layout

Sample reflowing

estruyf and others added 2 commits Jul 17, 2019
Merge for 1.14.0
@hugoabernier

This comment has been minimized.

Copy link
Contributor Author

hugoabernier commented Jul 30, 2019

Sorry, I just realized that I created my branch from the master branch instead of dev. I'll do better next time :-)

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 30, 2019

Codecov Report

Merging #350 into dev will increase coverage by 0.43%.
The diff coverage is 82.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #350      +/-   ##
==========================================
+ Coverage   72.88%   73.31%   +0.43%     
==========================================
  Files          17       18       +1     
  Lines         767      802      +35     
  Branches      149      154       +5     
==========================================
+ Hits          559      588      +29     
- Misses        161      164       +3     
- Partials       47       50       +3
Impacted Files Coverage Δ
src/controls/gridLayout/GridLayout.tsx 82.85% <82.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fb2e99...a277c99. Read the comment docs.

@hugoabernier

This comment has been minimized.

Copy link
Contributor Author

hugoabernier commented Jul 30, 2019

@estruyf I'm planning on adding components for the other standard web part layouts (e.g.: filmstrip, compact, etc.) as per the SharePoint Design layout patterns.

I'm planning on submitting each one as a separate PR. Would you prefer them as a single PR?

@hugoabernier hugoabernier mentioned this pull request Aug 18, 2019
@estruyf

This comment has been minimized.

Copy link
Collaborator

estruyf commented Sep 3, 2019

Thank you @hugoabernier, merged it to the DEV branch.

@estruyf estruyf added this to the 1.15.0 milestone Sep 3, 2019
@estruyf

This comment has been minimized.

Copy link
Collaborator

estruyf commented Sep 3, 2019

Something seems wrong with the Github merging. I manually merged it, code should be fine, but Github doesn't know the source location it seems.

Screenshot 2019-09-03 09 46 29

@estruyf estruyf closed this Sep 3, 2019
@hugoabernier

This comment has been minimized.

Copy link
Contributor Author

hugoabernier commented Sep 5, 2019

@estruyf I can resubmit as a single 'layout' control instead of individual 'grid', 'filmstrip', 'compact', 'carousel' layouts.

@estruyf

This comment has been minimized.

Copy link
Collaborator

estruyf commented Sep 5, 2019

This grid control has already been merged so all good here.

@estruyf estruyf mentioned this pull request Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.