Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live persona card #353

Open
wants to merge 1 commit into
base: dev
from

Conversation

@hugoabernier
Copy link
Contributor

commented Aug 5, 2019

Q A
Bug fix? [ ]
New feature? [ ]
New sample? [ ]
Related issues? Replaces PR #352, fixes #259

What's in this Pull Request?

Second attempt at submitting this. I included the wrong files in the previous one

Creates a wrapper around any HTML element that will present an Office 365 live persona card when users mouse over.

If you omit HTML elements, it will automatically render a default PersonaCard for the specified user.

This is the first version to resolve #259. I would like to look for opportunities to integrate with the FieldUserRenderer control and avoid duplicated code.

LivePersonaCard

@hugoabernier hugoabernier referenced this pull request Aug 5, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Aug 5, 2019

Codecov Report

Merging #353 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #353   +/-   ##
=======================================
  Coverage   72.88%   72.88%           
=======================================
  Files          17       17           
  Lines         767      767           
  Branches      149      149           
=======================================
  Hits          559      559           
  Misses        161      161           
  Partials       47       47

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fb2e99...1659569. Read the comment docs.

@wobba

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

The LPC is currently a first party component within Microsoft. We are aware of this approach taken to piggy-back on the person web part, which is not officially supported.

We will let this PR stay for now until we can verify if we can support this approach somehow. At least in a semi-official way, as we do understand the usecase for this 100%.

@hugoabernier hugoabernier changed the title Live person card -- second attempt Live persona card Aug 18, 2019

@hugoabernier

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2019

Thanks @wobba, completely understand. Is there anything the community can do to help with this? E.g.: uservoice, etc.?

@wobba

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2019

I'm tasked with evaluating pro/cons, why etc. Could take a little time, as there are multiple angels to cover. If I take too long reporting progress, remind me. Having a user voice for this is smart (if there isn't one).

@hugoabernier

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2019

I added a uservoice entry for this, please vote if this is something that would be useful to you.
https://sharepoint.uservoice.com/forums/329220-sharepoint-dev-platform/suggestions/38451154-provide-support-for-livepersonacard-in-3rd-party-s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.