Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilePicker control #366

Merged
merged 25 commits into from Sep 10, 2019

Conversation

@siata13
Copy link
Contributor

siata13 commented Sep 9, 2019

Q A
Bug fix? [ ]
New feature? [x]
New sample? [ ]

What's in this Pull Request?

PR contains a new control FilePicker that allows to select a file from various places.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 9, 2019

Codecov Report

Merging #366 into dev will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #366      +/-   ##
==========================================
- Coverage   73.31%   73.18%   -0.14%     
==========================================
  Files          18       18              
  Lines         802      798       -4     
  Branches      154      164      +10     
==========================================
- Hits          588      584       -4     
  Misses        164      164              
  Partials       50       50
Impacted Files Coverage Δ
src/loc/en-us.ts 100% <ø> (ø) ⬆️
src/controls/gridLayout/GridLayout.tsx 80.64% <0%> (-2.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5c58d3...f972238. Read the comment docs.

@siata13 siata13 changed the title Dev FilePicker control Sep 9, 2019
@estruyf estruyf merged commit f972238 into SharePoint:dev Sep 10, 2019
3 checks passed
3 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
license/cla All CLA requirements met.
Details
@estruyf

This comment has been minimized.

Copy link
Collaborator

estruyf commented Sep 10, 2019

Thanks @siata13 this is an amazing new control which adds a lot of value!!!!

@estruyf estruyf added this to the 1.15.0 milestone Sep 10, 2019
@estruyf estruyf mentioned this pull request Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.