Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated #355 #381

Merged
merged 4 commits into from Oct 8, 2019

Conversation

@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Oct 8, 2019

Q A
Bug fix? [ ]
New feature? [x]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Added the option to select a column to be the key / value of the select.
columnInternalName: is used for the text portion,
keyColumnInternalName?: is used for the key portion of the selected option.

Based on #355

estruyf and others added 3 commits Jul 17, 2019
Merge for 1.14.0
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 8, 2019

Codecov Report

Merging #381 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #381   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files          18       18           
  Lines         802      802           
  Branches      164      154   -10     
=======================================
  Hits          588      588           
  Misses        164      164           
  Partials       50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a373f03...7b9ea4b. Read the comment docs.

@AJIXuMuK AJIXuMuK merged commit b872181 into dev Oct 8, 2019
3 checks passed
3 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
license/cla All CLA requirements met.
Details
@AJIXuMuK AJIXuMuK deleted the mellolr1 branch Oct 8, 2019
@AJIXuMuK AJIXuMuK added this to the 1.15.0 milestone Oct 8, 2019
@estruyf estruyf mentioned this pull request Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.