Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing broken links from line 42 to 57 #388

Merged
merged 2 commits into from Nov 15, 2019

Conversation

@siddharth-vaghasia
Copy link
Contributor

siddharth-vaghasia commented Oct 15, 2019

Just added .md as extension to all the hyperlinks pointing to controls md file.

Q A

| Documentation updated |

What's in this Pull Request?

Fixed broken links to add extension ".md"

Guidance

  • You can delete this section when you are submitting the pull request.
  • Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
  • Please target your PR to dev branch.
estruyf and others added 2 commits Oct 14, 2019
Merge for 1.15.0
Just added .md as extension to all the hyperlinks pointing to controls md file.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 15, 2019

Codecov Report

Merging #388 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #388   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files          18       18           
  Lines         802      802           
  Branches      164      154   -10     
=======================================
  Hits          588      588           
  Misses        164      164           
  Partials       50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 856af11...b5373bf. Read the comment docs.

@siddharth-vaghasia

This comment has been minimized.

Copy link
Contributor Author

siddharth-vaghasia commented Oct 16, 2019

@estruyf ...I did not understand codecov report, please advise any action item on me.... I create this PR just to fix some broken links..

Thanks
Sid

@AJIXuMuK AJIXuMuK merged commit 6afcc41 into SharePoint:dev Nov 15, 2019
3 checks passed
3 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
license/cla All CLA requirements met.
Details
@AJIXuMuK

This comment has been minimized.

Copy link
Collaborator

AJIXuMuK commented Nov 15, 2019

Thank you @siddharth-vaghasia for that fix!

@AJIXuMuK AJIXuMuK added this to the 1.16.0 milestone Nov 15, 2019
@estruyf estruyf mentioned this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.