Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListItemPicker - Added new control property, "FilterList" #392

merged 5 commits into from Nov 15, 2019


Copy link

joaojmendes commented Oct 20, 2019

Bug fix? [ ]
New feature? [X]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Added new Control Property "FilterList", allows filter list items base on condition ($filter), and select item(s) on sub set of list Items.

estruyf and others added 2 commits Oct 14, 2019
Merge for 1.15.0

This comment has been minimized.

Copy link

codecov-io commented Oct 20, 2019

Codecov Report

Merging #392 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #392   +/-   ##
  Coverage   73.31%   73.31%           
  Files          18       18           
  Lines         802      802           
  Branches      164      154   -10     
  Hits          588      588           
  Misses        164      164           
  Partials       50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 856af11...959035b. Read the comment docs.

@AJIXuMuK AJIXuMuK mentioned this pull request Nov 15, 2019
AJIXuMuK added a commit that referenced this pull request Nov 15, 2019

Merge of #392
@AJIXuMuK AJIXuMuK merged commit efd2240 into SharePoint:dev Nov 15, 2019
3 checks passed
3 checks passed
ci/circleci: build Your tests passed on CircleCI!
ci/circleci: test Your tests passed on CircleCI!
license/cla All CLA requirements met.

This comment has been minimized.

Copy link

AJIXuMuK commented Nov 15, 2019

Hi @joaojmendes!
Thank you for that feature!
The PR has been manually fixed in #416.
I have additionally renamed filterList property to filter so it would be more meaningful for users.

@AJIXuMuK AJIXuMuK added this to the 1.16.0 milestone Nov 15, 2019

This comment has been minimized.

Copy link
Contributor Author

joaojmendes commented Nov 15, 2019

@estruyf estruyf mentioned this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.