Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #405, when using drop down for time display, value is now formatt… #409

Merged
merged 1 commit into from Nov 15, 2019

Conversation

@c-eiser13
Copy link
Contributor

c-eiser13 commented Nov 5, 2019

…ed properly with space between hours and designator.

Q A
Bug fix? [X ]
New feature? [ ]
New sample? [ ]
Related issues? fixes #405

What's in this Pull Request?

In the HoursComponent of the DateTimePicker, updated the onChange function of the Dropdown control to pass the value to the TimeHelper.hoursValue function so it will be formatted as the DateTimePicker component expects it to be.

Previous: onChange(option.text)
New: onChange(TimeHelper.hoursValue(option.key as number, this.props.timeConvention))

…ed properly with space between hours and designator.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #409 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #409   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files          18       18           
  Lines         802      802           
  Branches      164      164           
=======================================
  Hits          588      588           
  Misses        164      164           
  Partials       50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e382c5e...804bcc4. Read the comment docs.

@AJIXuMuK AJIXuMuK merged commit bde4bfc into SharePoint:dev Nov 15, 2019
3 checks passed
3 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
license/cla All CLA requirements met.
Details
@AJIXuMuK

This comment has been minimized.

Copy link
Collaborator

AJIXuMuK commented Nov 15, 2019

Thanks for the fix @c-eiser13!

@AJIXuMuK AJIXuMuK added this to the 1.16.0 milestone Nov 15, 2019
@estruyf estruyf mentioned this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.