Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Align Left button not working. #429

Closed
wants to merge 2 commits into from

Conversation

@SharePickle
Copy link
Contributor

SharePickle commented Dec 6, 2019

Q A
Bug fix? [x]
New feature? [ ]
New sample? [ ]

What's in this Pull Request?

Changed format arguments from left to undefined to fix issue where quill editor won't alignt text to the left.
undefined is the correct argument when aligning to the left.

SharePickle added 2 commits Dec 6, 2019
Quill's left align format requires `undefined` as an argument not a string `left`.
Fixed Align Left button not working.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 6, 2019

Codecov Report

Merging #429 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #429   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files          18       18           
  Lines         802      802           
  Branches      164      164           
=======================================
  Hits          588      588           
  Misses        164      164           
  Partials       50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc3baf5...59551bb. Read the comment docs.

@AJIXuMuK

This comment has been minimized.

Copy link
Collaborator

AJIXuMuK commented Dec 6, 2019

Thank you @SharePickle for the change!
The PR was manually merged into dev branch.

@AJIXuMuK AJIXuMuK closed this Dec 6, 2019
@estruyf estruyf mentioned this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.