Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doubled scroll issue when iframe content is higher than frame height #431

Merged
merged 1 commit into from Dec 11, 2019

Conversation

@bbronisz
Copy link

bbronisz commented Dec 6, 2019

Q A
Bug fix? [ x]
New feature? [ ]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

It fixes double scrolls on different browsers due to wrong height calculations of iframe content, due to:

  • selectors without . for classes
  • marginTop style's value used to calculate marginBottom
  • usage of style property on element (it was empty e.g. on Chrome) instead of window.getComputedStyle
  • too small value used for padding (at least on Firefox and Chrome)
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 6, 2019

Codecov Report

Merging #431 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #431   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files          18       18           
  Lines         802      802           
  Branches      154      164   +10     
=======================================
  Hits          588      588           
  Misses        164      164           
  Partials       50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 121af1a...d58260d. Read the comment docs.

@AJIXuMuK

This comment has been minimized.

Copy link
Collaborator

AJIXuMuK commented Dec 11, 2019

Great job @bbronisz!
Thank you for the fixes!

@AJIXuMuK AJIXuMuK merged commit f742183 into SharePoint:dev Dec 11, 2019
3 checks passed
3 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
license/cla All CLA requirements met.
@AJIXuMuK AJIXuMuK added this to the 1.16.0 milestone Dec 11, 2019
@bbronisz bbronisz deleted the bbronisz:dev branch Dec 11, 2019
@estruyf estruyf mentioned this pull request Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.