Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sample: react-command-page-model-pnpjs #213

Merged
merged 16 commits into from Apr 8, 2019

Conversation

Projects
None yet
3 participants
@fredupstair
Copy link
Contributor

commented Mar 23, 2019

Q A
Bug fix? no
New feature? no
New sample? yes
Related issues? n.a.

What's in this Pull Request?

New sample. SPFx extension using @pnp/pnpjs , that allows creating Modern Pages hard-coded or based on prefilled modern pages marked as "Page Model", inside the Site Pages Library.

@msftclas

This comment has been minimized.

Copy link

commented Mar 23, 2019

CLA assistant check
All CLA requirements met.

@VesaJuvonen VesaJuvonen merged commit cc31839 into SharePoint:dev Apr 8, 2019

1 check passed

license/cla All CLA requirements met.
Details
@VesaJuvonen

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

thx @fredupstair, really cool setup. Would you be interested in doing a live demo of this in any of the upcoming SPFx community calls? Would be a nice sample to demonstrate and share the learnings.

@fredupstair

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

Thank you for the merge @VesaJuvonen ! About the live demo, of course, I'd like to do it let me know when :)

@VesaJuvonen

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

Hi @fredupstair, we would have 10-15 min spot in the 24th of April call if that works for you. We will have 3 demos in that call, so timing will be strict, but should be doable... to show the main behavior and then key points from the code. Works?

@fredupstair

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

Hi @VesaJuvonen , that's ok! 10/15 minutes are fine, I'll try to do something simple but effective. Let me know any other details. Thank you so much :)

@VesaJuvonen

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

Souds good - thx @fredupstair. I'll add you to the agenda related to this sample. Thx for volunteering.

@VesaJuvonen

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

ah - it's btw 25th of April, not on 24th which hopefully does not have an impact on this.

@fredupstair

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

no problem @VesaJuvonen , 25th is good as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.