New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyFieldCollectionData - Support custom fields with string values (i.e. code editor) #122

Closed
FranckyC opened this Issue Dec 1, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@FranckyC
Copy link

FranckyC commented Dec 1, 2018

I'm currently working to integrate a result types feature to the react-search-refiners sample and I would like to use the PropertyFieldCollectionData to edit the HTML code for a specific condition set. With current options, I'm able to render the condition as string fields (property, operator, and value) but I'm struggling to add a code editor field.

My first attempt was to use the onRenderOption method with a dropdown field. With this, I'm able to open a code editor dialog from a button option but I'm not able to get back the result and associate it to the PropertyFieldCollectionData corresponding field.

Would it be possible to support custom fields with, for instance onRender/onUpdate methods for the PropertyFieldCollectionData control?

I could implement such a control myself but except this issue, the PropertyFieldCollectionData suits this scenario very well.

Category

  • Enhancement
  • Bug
  • Question

Version

1.12.0

Expected / Desired Behavior / Question

Support custom fields with string values like a code editor.

estruyf added a commit that referenced this issue Dec 6, 2018

@estruyf estruyf added the enhancement label Dec 6, 2018

@estruyf estruyf added this to the 1.13.0 milestone Dec 6, 2018

@estruyf

This comment has been minimized.

Copy link
Collaborator

estruyf commented Dec 6, 2018

@FranckyC this is an amazing idea which is now implemented in the current beta version.

Feel free to test it out and check if it meets your needs. The initial implementation is very basic, it allows you to override the rendering and tell the value to update.

More information about how to install a beta version can be found here: https://sharepoint.github.io/sp-dev-fx-property-controls/beta/

The documentation for the control has been updated. At the moment it is not yet live, so you have to check it in the DEV branch: https://github.com/SharePoint/sp-dev-fx-property-controls/blob/dev/docs/documentation/docs/controls/PropertyFieldCollectionData.md

@FranckyC

This comment has been minimized.

Copy link

FranckyC commented Dec 6, 2018

Nice, I'll test this ASAP.

@FranckyC

This comment has been minimized.

Copy link

FranckyC commented Dec 11, 2018

@estruyf Works as expected. Thanks!

image

Do you have an ETA for the 1.13.0 release?

@estruyf

This comment has been minimized.

Copy link
Collaborator

estruyf commented Dec 11, 2018

Amazing news @FranckyC, aiming for later this week.

@estruyf estruyf closed this Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment