New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyFieldCollectionData - 1.13.0 - 'Each child in an array or iterator should have a unique "key" prop' on first WP configuration #128

Closed
FranckyC opened this Issue Dec 13, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@FranckyC
Copy link

FranckyC commented Dec 13, 2018

After installing the new released 1.13.0 version, the sorting seems to break (see screenshot). Using the beta version was fine.

Category

  • Enhancement
  • [ X] Bug
  • Question

Version

Please specify what version of the library you are using: [1.13.0]

The property pane property is configured as follow (with enableSorting):

PropertyFieldCollectionData('resultTypes', {
                manageBtnLabel: strings.ResultTypes.EditResultTypesLabel,
                key: 'resultTypes',
                panelHeader: strings.ResultTypes.EditResultTypesLabel,
                panelDescription: strings.ResultTypes.ResultTypesDescription,
                enableSorting: true,
                label: strings.ResultTypes.ResultTypeslabel,
                value: this.properties.resultTypes,
                fields: [
                    ...

image

@FranckyC

This comment has been minimized.

Copy link

FranckyC commented Dec 13, 2018

This error only appears during the first instantiation. Not sure if related to the sorting option. I tried to add a key to my own custom control but the behavior is the same. Anyway not really important for now since I can use the component.

@FranckyC FranckyC changed the title PropertyFieldCollectionData - 1.13.0 - Error with sorting option PropertyFieldCollectionData - 1.13.0 - React error 'key' is missing on first WP instantiation Dec 13, 2018

@FranckyC FranckyC changed the title PropertyFieldCollectionData - 1.13.0 - React error 'key' is missing on first WP instantiation PropertyFieldCollectionData - 1.13.0 - 'Each child in an array or iterator should have a unique "key" prop' on first WP configuration Dec 13, 2018

@estruyf

This comment has been minimized.

Copy link
Collaborator

estruyf commented Dec 13, 2018

@FranckyC that's indeed weird, will check out what's going on, and release a bug fix.

estruyf added a commit that referenced this issue Dec 13, 2018

@estruyf

This comment has been minimized.

Copy link
Collaborator

estruyf commented Dec 13, 2018

It seems to only occur in the local workbench. Just released v1.13.1 as a beta with the included fix.

@estruyf estruyf closed this Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment