Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up[PropertyFieldColorPicker]: Add isHidden property #138
Comments
RogerZhang-CatapultSystems
changed the title
[PropertyFieldColorPicker]: Add isVisible property
[PropertyFieldColorPicker]: Add isHidden property
Jan 3, 2019
RogerZhang-CatapultSystems
referenced this issue
Jan 4, 2019
Merged
Property field color picker is hidden property support #140
estruyf
added this to the 1.14.0 milestone
Jan 19, 2019
This comment has been minimized.
This comment has been minimized.
This will be available in version |
estruyf
closed this
Jan 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
RogerZhang-CatapultSystems commentedJan 3, 2019
•
edited
Category
Version
We are using latest package 1.13.1
Expected
PropertyFieldColorPicker need to support isHidden property.
FYI: As we have the user scenario of setting the background of the web part. In the web part's configuration pane, we provide client an drop down property called background-color setting, which provide client the options: 'Use Site Theme', "Use Invert Site Theme", "Custom Color", if the "Custom color" option was selected , we want the propertyFieldColorPicker field displayed and editable , else hidden.
With the latest version of propertyFieldColorPicker, the only way is using disable property, but the color picker field still be displayed, the user experience is not good.
Thanks!