New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PropertyFieldColorPicker]: Add isHidden property #138

Closed
RogerZhang-CatapultSystems opened this Issue Jan 3, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@RogerZhang-CatapultSystems
Copy link
Contributor

RogerZhang-CatapultSystems commented Jan 3, 2019

Category

  • Enhancement

Version

We are using latest package 1.13.1

Expected

PropertyFieldColorPicker need to support isHidden property.

FYI: As we have the user scenario of setting the background of the web part. In the web part's configuration pane, we provide client an drop down property called background-color setting, which provide client the options: 'Use Site Theme', "Use Invert Site Theme", "Custom Color", if the "Custom color" option was selected , we want the propertyFieldColorPicker field displayed and editable , else hidden.

With the latest version of propertyFieldColorPicker, the only way is using disable property, but the color picker field still be displayed, the user experience is not good.

Thanks!

@RogerZhang-CatapultSystems RogerZhang-CatapultSystems changed the title [PropertyFieldColorPicker]: Add isVisible property [PropertyFieldColorPicker]: Add isHidden property Jan 3, 2019

@estruyf estruyf added this to the 1.14.0 milestone Jan 19, 2019

@estruyf

This comment has been minimized.

Copy link
Collaborator

estruyf commented Jan 19, 2019

This will be available in version 1.14.0.

@estruyf estruyf closed this Jan 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment