Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PropertyFieldDropdownWithCallout]: Options of type "Divider" and "Header" are ignored #145

Closed
spplante opened this issue Jan 12, 2019 · 6 comments

Comments

Projects
None yet
3 participants
@spplante
Copy link
Contributor

commented Jan 12, 2019

Category

  • Enhancement
  • Bug
  • Question

Version

1.13.1

Expected / Desired Behavior / Question

When using the PropertyFieldDrdopdownWithCallout, we should be able to specify options that have their type property set to PropertyPaneDropdownOptionType.Header or PropertyPaneDropdownOptionType.Divider in order to display headers and dividers accordingly in the options.

Observed Behavior

While the out-of-the-box PropertyPaneDropdown does renders header and divider options correctly, it seems like the PropertyFieldDrdopdownWithCallout is only looking at the key and text property in order to renders the options, which leads to the headers and dividers being rendered as regular selectable options.

Steps to Reproduce

Use the PropertyFieldDrdopdownWithCallout with some headers and dividers and see the resulting options.

@AJIXuMuK

This comment has been minimized.

Copy link
Contributor

commented Jan 14, 2019

Will look into it...

AJIXuMuK added a commit to AJIXuMuK/sp-dev-fx-property-controls that referenced this issue Mar 2, 2019

@AJIXuMuK AJIXuMuK referenced this issue Mar 2, 2019

Merged

fix for #145 #167

@AJIXuMuK

This comment has been minimized.

Copy link
Contributor

commented Mar 2, 2019

Finally looked into it :) The fix has been committed

@spplante

This comment has been minimized.

Copy link
Contributor Author

commented Mar 2, 2019

Great news thanks!

estruyf added a commit that referenced this issue May 17, 2019

@estruyf estruyf added this to the 1.14.2 milestone May 17, 2019

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2019

This will be available in the 1.15.0 release and can already be tested in the latest beta.

Here you can read how you can install the latest beta: https://sharepoint.github.io/sp-dev-fx-property-controls/beta/

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented May 22, 2019

This has just been released in version 1.15.0.

@estruyf estruyf closed this May 22, 2019

@spplante

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

Just tested this and it works as expected 👍

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.