Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnterpriseTermPicker loading children under wrong nodes. #156

Closed
gbminnock opened this Issue Feb 8, 2019 · 8 comments

Comments

Projects
None yet
3 participants
@gbminnock
Copy link

gbminnock commented Feb 8, 2019

Hi I am have some issues with the terms. They seem not to be loading correctly. The children seem to be sorted but are not attached to the correct parents.

Thanks,
Gary

Category

  • Bug

Version

Please specify what version of the library you are using: [ 1.14.0 ]

If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.

Expected / Desired Behavior / Question

Expected terms to load under correct parent.

Observed Behavior

All terms are loading but it seems that this child terms are sorted (irrespective of parent) and then are attached to the incorrect parent.

Steps to Reproduce

Setup as per instructions. Here are the properties I use:

PropertyFieldEnterpriseTermPicker('terms', {
                  label: 'Select terms',
                  panelTitle: 'Select terms',
                  allowMultipleSelections: false,
                  excludeSystemGroup: true,
                  onPropertyChange: this.onPropertyPaneFieldChanged,
                  properties: this.properties,
                  context: this.context,
                  onGetErrorMessage: null,
                  deferredValidationTime: 0,
                  limitByGroupNameOrID: 'Planes',
                  key: 'termSetsPickerFieldId',
                  includeLabels: true,
                  isTermSetSelectable: true,
                  hideTermStoreName: true
                })
@AJIXuMuK

This comment has been minimized.

Copy link
Contributor

AJIXuMuK commented Feb 8, 2019

Hi @gbminnock,
Could you please provide screenshots of how the component’s tree is rendered and how the hierarchy looks at Term Management Store?

@estruyf

This comment has been minimized.

Copy link
Collaborator

estruyf commented Feb 8, 2019

@gbminnock this is probably related to: #153. I already implemented a fix for this. You can verify it yourself by installing the latest beta version. More information how you can install the latest beta can be found here: https://sharepoint.github.io/sp-dev-fx-property-controls/beta/

@gbminnock

This comment has been minimized.

Copy link
Author

gbminnock commented Feb 11, 2019

Hi @AJIXuMuK & @estruyf,

I've installed the beta release this morning but am still seeing the same issue.
version
"@pnp/spfx-property-controls": "1.14.1-beta.db31aed"
pnp version

  "@pnp/common": "^1.2.8",
    "@pnp/logging": "^1.2.8",
    "@pnp/odata": "^1.2.8",
    "@pnp/sp": "^1.2.8",
    "@pnp/sp-clientsvc": "^1.2.8",
    "@pnp/sp-taxonomy": "^1.2.8",

I have copied the test case provided by the user in #153.

term store management

image

webpart

image

Tks,
Gary

@estruyf

This comment has been minimized.

Copy link
Collaborator

estruyf commented Feb 11, 2019

@gbminnock overlooked the enterprise part, so it could indeed be that the issue needs to be also fixed on that one.

@estruyf

This comment has been minimized.

Copy link
Collaborator

estruyf commented Feb 11, 2019

@gbminnock implemented the fix, and the new beta version is available. Could you please verify if it fixes the issue on your end?

@gbminnock

This comment has been minimized.

Copy link
Author

gbminnock commented Feb 12, 2019

@estruyf yes its working fine now. Tks
image

@estruyf

This comment has been minimized.

Copy link
Collaborator

estruyf commented Feb 13, 2019

Thanks for verifying!

@estruyf estruyf added this to the 1.14.1 milestone Feb 13, 2019

@estruyf estruyf referenced this issue Feb 13, 2019

Merged

Prepare v1.14.1 #163

@estruyf

This comment has been minimized.

Copy link
Collaborator

estruyf commented Feb 13, 2019

A new version is building at the moment. This fix will be available in version 1.14.1.

@estruyf estruyf closed this Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.