Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyFieldTextWithCallout still persist property value when error #172

Closed
spplante opened this issue Apr 19, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@spplante
Copy link
Contributor

commented Apr 19, 2019

Category

  • Enhancement
  • Bug
  • Question

Version

1.14.1

Expected / Desired Behavior / Question

With the PropertyFieldTextWithCallout control, when an error is returned from the onGetErrorMessage callback property after the text has changed, the WebPart property should not get persisted with the invalid value and should keep it's old value, just like the OOTB TextField property pane.

Observed Behavior

When the onGetErrorMessage returns an error because the value is invalid, the WebPart property still persists the invalid value.

Steps to Reproduce

Use the PropertyFieldTextWithCallout, return an error from the the onGetErrorMessage callback and notice how the value still gets persisted.

@AJIXuMuK AJIXuMuK referenced this issue Apr 22, 2019

Merged

Fix of 172 #173

@estruyf estruyf added this to the 1.14.2 milestone May 17, 2019

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2019

@spplante - @AJIXuMuK implemented a fix for this and is now available in the latest beta. Feel free to test it out.

More information on how you can install the latest beta can be found here: https://sharepoint.github.io/sp-dev-fx-property-controls/beta/

@estruyf estruyf modified the milestones: 1.14.2, v1.15.0 May 17, 2019

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented May 22, 2019

This has just been released in version 1.15.0.

@estruyf estruyf closed this May 22, 2019

@spplante

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

Just tested this and it works as expected 👍

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.