Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callout icon missing with 1.8.2 web part #178

Closed
c-eiser13 opened this issue May 14, 2019 · 6 comments

Comments

Projects
None yet
3 participants
@c-eiser13
Copy link

commented May 14, 2019

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!

Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.

Category

  • Enhancement
  • [X ] Bug
  • Question

Version

Please specify what version of the library you are using: [ 1.14.1 ]

If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.

Expected / Desired Behavior / Question

MS Info icon renders to the right of the link/button/label.

Observed Behavior

I am trying to use PropertyFieldLinkWithCallout in a 1.8.2 SPFx web part and the icon does not show up. I tested downgrading to 1.12.0 and 1.13.0 and both exhibit same behavior in a 1.8.2 web part. I then switched over to a 1.7.1 web part and the Info UIF icon displays correctly.
SPFx 1.8.2 web part:
1 8 prop pane

SPFx 1.7.1 web part:
1 7 prop pane

1.8.2 in browser:
1 8browser

1 80x0

1 8css

1.7.1 in browser:
1 7browser

Icon Inspected:
1 7 font family

Main difference I can see is the font-family is correct in 1.7.1 and not in 1.8.2. If there is anything else I can provide to assist, just let me know. Thanks for the great set of controls!

Steps to Reproduce

Create a new 1.8.2 SPFx web part and add any callout control to the property pane.

@msftbot

This comment has been minimized.

Copy link

commented May 14, 2019

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

AJIXuMuK pushed a commit to AJIXuMuK/sp-dev-fx-property-controls that referenced this issue May 14, 2019

@AJIXuMuK AJIXuMuK referenced this issue May 14, 2019

Merged

fix of #178 #179

@AJIXuMuK

This comment has been minimized.

Copy link
Contributor

commented May 14, 2019

Thank you @c-eiser13 for reporting the issue.
I've added the PR that will fix the issue for the latest versions of SPFx.

@c-eiser13

This comment has been minimized.

Copy link
Author

commented May 14, 2019

Thanks for the quick response @AJIXuMuK ! I found a similar issue in the fileTypeIcon control and I've logged an issue in that repo as well.

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2019

@AJIXuMuK thanks for fixing this.

@c-eiser13 this is now implemented in the latest beta, feel free to test it out. Here you can read how you can install the latest beta: https://sharepoint.github.io/sp-dev-fx-property-controls/beta/

@estruyf estruyf modified the milestones: 1.14.2, v1.15.0 May 17, 2019

@c-eiser13

This comment has been minimized.

Copy link
Author

commented May 19, 2019

Thanks @AJIXuMuK and @estruyf I've installed the beta and can confirm it is fixed. Appreciate the quick turnaround!

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented May 22, 2019

This has just been released in version 1.15.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.