Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional controls missing callout icon in 1.8.2 web parts #182

Closed
c-eiser13 opened this issue May 29, 2019 · 2 comments

Comments

@c-eiser13
Copy link
Contributor

commented May 29, 2019

Category

  • Enhancement
  • [ x] Bug
  • Question

Version

Please specify what version of the library you are using: [ ]

If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.

Expected / Desired Behavior / Question

Using Toggle with callout in 1.8.2 web part and info icon is visible.

Observed Behavior

When using any property control that references common/propertyFieldHeader instead of common/placeholderWithCallout, the info icon is missing. Looking at the fix that was made in common/placeholderWithCallout, I've created a PR and made the same update in common/propertyFieldHeader (#178) and the callout controls relying on this now work properly.

I will update this post with the PR info.

Steps to Reproduce

Create 1.8.2 SPFx project and use Text with callout or toggle with callout (others as well).

Thanks!

@msftbot

This comment has been minimized.

Copy link

commented May 29, 2019

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

c-eiser13 added a commit to c-eiser13/sp-dev-fx-property-controls that referenced this issue May 29, 2019

estruyf added a commit that referenced this issue Jul 9, 2019

@estruyf estruyf added this to the 1.16.0 milestone Jul 9, 2019

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

This PR got merged and will be available in version 1.16.0. You can already test it out via installing the latest beta version.

@estruyf estruyf closed this Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.