Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: all the getting started links are broken #191

Closed
baywet opened this issue Jul 10, 2019 · 2 comments

Comments

@baywet
Copy link

commented Jul 10, 2019

Category

  • Enhancement
  • Bug
  • Question

Version

Please specify what version of the library you are using: Documentation related issue.

Expected / Desired Behavior / Question

Getting started link to point to the proper page (eg for this page https://sharepoint.github.io/sp-dev-fx-property-controls/controls/PropertyPaneWebPartInformation/)

Observed Behavior

Getting started points to a in-existing page, (notice the controls path section which shouldn't be there)

Steps to Reproduce

Open this page https://sharepoint.github.io/sp-dev-fx-property-controls/controls/PropertyPaneWebPartInformation/ click on Getting Started

Potential fixes

I'm not sure whether we should replace the link by ../#getting-started or index.md#getting-started (so MkDocs picks it up properly and replaces the link for us) or if a MkDocs configuration issue.
If it's not the last option, I'll be happy to PR away once I get guidance.

@msftbot

This comment has been minimized.

Copy link

commented Jul 10, 2019

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

estruyf added a commit that referenced this issue Jul 17, 2019

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2019

Thanks @baywet this has been fixed

@estruyf estruyf added this to the 1.16.0 milestone Jul 17, 2019

@estruyf estruyf closed this in #192 Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.