Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyFieldColorPicker Palette Icon alignment issue in IE11 #56

Closed
sprider opened this issue Apr 25, 2018 · 4 comments

Comments

@sprider
Copy link

commented Apr 25, 2018

Category

  • Bug

Version

1.5.1 and above including beta

Expected

Fix the alignment issue as you see below or open the color palette as a callout
chrome

Observed Behavior

In IE11 the PropertyFieldColorPicker Palette Icon seems to hide when active which creates mild confusion on closing.
ie 11

Steps to Reproduce

  1. Create a SPFx webpart
  2. Install sp-dev-fx-property-controls package as mentioned in https://sharepoint.github.io/sp-dev-fx-property-controls/
  3. Add PropertyFieldColorPicker property
  4. Execute the app using gulp serve
  5. Open the local workbench page in IE11 and add the app
  6. Edit the PropertyFieldColorPicker property
  7. Notice the icon alignment issue

Thanks!

@sprider

This comment has been minimized.

Copy link
Author

commented Apr 30, 2018

Please verify in Edge browser as well

@sprider

This comment has been minimized.

Copy link
Author

commented May 1, 2018

Sometimes the icon is hiding in windows when i have other web parts in the page. Please verify this scenario before you deploy 1.6.0

screen shot 2018-05-01 at 8 36 41 am

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented May 7, 2018

I cannot seem to reproduce this issue in Edge. @thechriskent can you?

@thechriskent

This comment has been minimized.

Copy link
Member

commented May 8, 2018

I'm not seeing any issues in Edge or IE.

Here is a screenshot of a webpart using this control alongside other webparts on a communication site using the Edge browser:

image

Here is the control where multiple property pages are being used (as in your screenshot) also in Edge:

image

I'm going to close the issue for now, but if you continue to experience these issues please feel free to reopen with any additional details about when this is happening. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.