Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PropertyFieldDateTimePicker] Add ability to hide labels in front of the pickers #77

Closed
tsekityam opened this issue Jul 4, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@tsekityam
Copy link

commented Jul 4, 2018

Category

  • Enhancement
  • Bug
  • Question

Version

Please specify what version of the library you are using: 1.7.0

Expected / Desired Behavior / Question

I expected the PropertyFieldDateTimePicker should have a look and feel similar to the date time picker we had in SharePoint list.
screen shot 2018-07-04 at 5 01 50 pm

I would like to suggest add a property to the control, such that user can disable the label.

Observed Behavior

Now we have labels before date time pickers property control, however, no any other default property controls nor pnp property controls has label in front of the controls. If we use date time picker control together with another property controls, the date time picker control looks odd.

screen shot 2018-07-04 at 5 15 48 pm

Steps to Reproduce

N/A

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented Jul 30, 2018

Thanks @tsekityam for the suggestion!

@tsekityam

This comment has been minimized.

Copy link
Author

commented Aug 4, 2018

I will write a patch to remove those labels from the control.

AJIXuMuK added a commit to AJIXuMuK/sp-dev-fx-property-controls that referenced this issue Mar 2, 2019

@estruyf estruyf added this to the 1.14.2 milestone May 17, 2019

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2019

This has now been implemented in the latest beta. Feel free to test it out.

Here you can read how you can install the latest beta: https://sharepoint.github.io/sp-dev-fx-property-controls/beta/

Add the property showLabels with the value set to false to the PropertyFieldDateTimePicker property pane control in order to hide the labels.

@estruyf estruyf modified the milestones: 1.14.2, v1.15.0 May 17, 2019

@estruyf

This comment has been minimized.

Copy link
Collaborator

commented May 22, 2019

This has just been released in version 1.15.0.

@estruyf estruyf closed this May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.