New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Todo Basic upgrade to release 1.1.0, replace removed Placeholde… #260

Merged
merged 1 commit into from Jul 21, 2017

Conversation

Projects
None yet
3 participants
@eoverfield
Contributor

eoverfield commented Jul 13, 2017

Replace and removed Placeholder component with custom Component

Q A
Bug fix? yes
New feature? no
New sample? no
Related issues? fixes issue 667: SharePoint/sp-dev-docs#677 (comment)

What's in this Pull Request?

SPFx 1.1.0 drops the Placeholder element from sp-webpart-base. This update looks to replace the placeholder with a like function to speed up configuration

@msftclas

This comment has been minimized.

Show comment
Hide comment
@msftclas

msftclas Jul 13, 2017

@eoverfield,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

msftclas commented Jul 13, 2017

@eoverfield,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@VesaJuvonen VesaJuvonen merged commit 536468b into SharePoint:dev Jul 21, 2017

@VesaJuvonen

This comment has been minimized.

Show comment
Hide comment
@VesaJuvonen

VesaJuvonen Jul 21, 2017

Contributor

thx Eric, appreciated.

Contributor

VesaJuvonen commented Jul 21, 2017

thx Eric, appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment