New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated script editor web part to 1.4 and minor updates #396

Merged
merged 10 commits into from Jan 20, 2018

Conversation

Projects
None yet
2 participants
@wobba
Contributor

wobba commented Jan 10, 2018

Q A
Bug fix? no
New feature? yes
New sample? no
Related issues?

What's in this Pull Request?

  • Updated web part to drop 1.4 and use of asset packing
  • Fixed ouif styles reference
  • Added property to toggle padding of web part zone on/off for "invisible" web parts - e.g. an anchor tag for scrolling, or script which does not render anything.
  • Refactorings

wobba added some commits Jan 10, 2018

Upgraded to drop 1.4 and asset bundling
Bumped version to 1.0.0.3
Refactored to have local function bindings at the top for better read…
…ability.

Fixed readonly warning in cancel dialog as property was set directly instead of via setState
Replaced safeWithCustomScriptDisabled with requiresCustomScript
Added removePadding property.
Updated correct schema reference.
Removed comments.

@wobba wobba changed the title from Improvement script ed part to Updated script editor web part to 1.4 and minor updates Jan 10, 2018

@VesaJuvonen VesaJuvonen merged commit 92ca13f into SharePoint:dev Jan 20, 2018

1 check passed

license/cla All CLA requirements met.
Details
@VesaJuvonen

This comment has been minimized.

Show comment
Hide comment
@VesaJuvonen

VesaJuvonen Jan 20, 2018

Contributor

Thx Mikael, appreciated.

Contributor

VesaJuvonen commented Jan 20, 2018

Thx Mikael, appreciated.

@wobba wobba deleted the wobba:ImprovementScriptEdPart branch Jan 25, 2018

wobba added a commit to wobba/sp-dev-fx-webparts that referenced this pull request Mar 26, 2018

Updated script editor web part to 1.4 and minor updates (SharePoint#396)
* Upgraded to drop 1.4 and asset bundling
Bumped version to 1.0.0.3

* Clean up of CSS

* Remove linting rule which caused warning on build

* Added property to toggle web part container padding on/off

* Refactored to have local function bindings at the top for better readability.
Fixed readonly warning in cancel dialog as property was set directly instead of via setState

* Replaced safeWithCustomScriptDisabled with requiresCustomScript
Added removePadding property.
Updated correct schema reference.
Removed comments.

* Added skipFeatureDeployment attribute for easier switch if needed.

* Added missing ;

* Fix for setting the default switch to require custom script enabled for the web part. Value got switched one the attribute changed.

* Added hyperlink on Puzzlepart logo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment