Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added View Formatting Example for Planner Inspired Task Cards #172

Merged
merged 13 commits into from Aug 13, 2019

Conversation

@aprildunnam
Copy link
Contributor

commented Aug 2, 2019

Q A
Bug fix? no - yes?
New sample? no - yes?
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Please describe the changes in this PR. Sample description or details around bugs which are being fixed.

Guidance

You can delete this section when you are submitting the pull request.

  • Please update this PR information accordingly. We'll use this as part of our release notes in monthly communications.
  • Please target your PR to 'master' branch.

Thanks for your contribution! Sharing is caring.

aprildunnam and others added 7 commits Feb 20, 2019
Added Links, minor formatting, and added analytics image tag
Renamed json file and normalized spacing
Adjusted Link
This View Formatting created Microsoft Planner-esq cards for task items.
Formats a SharePoint list to look like Twitter.  Pulls in Twitter profile image, links to profile, share icon that links to tweet, retweet icon shows # of retweets
@thechriskent thechriskent self-assigned this Aug 12, 2019
Fixed Table issue (columns were backwards in view requirements)
Added choice values
Added tracking image
Switched column to use no space internally
Removed unused neutral bgColor classes from root
Removed extra icon elements (combined into expression)
Fixed profile picture tooltip
Removed calendar icon when due date not provided
Now works in Dark themes
Added missing view requirement column
Simplified format
Added Tracking image
Adjusted colors to use themes to support dark themes
@thechriskent thechriskent merged commit 566f52e into SharePoint:master Aug 13, 2019
1 check passed
1 check passed
license/cla All CLA requirements met.
Details
@thechriskent

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

Thanks @aprildunnam! These samples look great!

Again, sorry for the delay. Thanks for reaching out and letting me know.

I've gone ahead and made several tweaks and merged this PR but here's a couple of things to keep in mind for next time:

  • When starting a new sample, please either delete your fork and refork (so you start fresh) or merge master from this repo into your branch to avoid conflicts (this PR had conflicts because of changes taking place after your last PR)
  • Please limit your PRs to a single sample at a time. This makes them easier to process and track.
  • Please fill out the PR template above by using the checkboxes, describing the samples, and removing the portions that should be deleted.
  • Ensure the tracking image from the README template is in your README files (just tweak it for your sample)
  • Check the commits I made to your samples above to get an idea of some of the other things samples should account for.

Please don't take any of the above wrong. These samples really are very cool and we're very glad to have them! You're becoming one of our top contributors to this repo and I just want to help make things easier. Thanks again for the great samples! Good luck at the conference, I'm sure the audience will love it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.